Fix generic system in chainable controllers

[InigoMoreno]

Fixes #2250

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.94%. Comparing base (73d5dca) to head (44e3933).
Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2252      +/-   ##
==========================================
- Coverage   88.97%   88.94%   -0.03%     
==========================================
  Files         143      143              
  Lines       16449    16453       +4     
  Branches     1422     1424       +2     
==========================================
- Hits        14635    14634       -1     
- Misses       1262     1266       +4     
- Partials      552      553       +1     

Flag	Coverage Δ
unittests	88.94% <100.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...e_interface/src/mock_components/generic_system.cpp	83.96% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[InigoMoreno]

The failures in the workflow seem to be unrelated to this pull request

[christophfroehlich]

Isn't this probably be "auto-fixed" with #2120 @saikishor?
We should add a test for that, but where would it fit? test_controllers_chaining_with_controller_manager.cpp with using generic_system instead of test_actuator?

[saikishor]

Isn't this probably be "auto-fixed" with #2120 @saikishor? We should add a test for that, but where would it fit? test_controllers_chaining_with_controller_manager.cpp with using generic_system instead of test_actuator?

You are absolutely right. #2120 should avoid this issue. The tests are already added in the PR: #2120 right?

[bmagyar]

@InigoMoreno could you please check if the issue still persists with the latest master branch? Is there any other case your PR would solve or are we good to close it unmerged?