Deactivate the controller chain upon failed group activation (backport #2669) #2737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue recently that one of the upper-level torque reference provider controllers failed to activate, and this has caused the other controllers in the chain to have an invalid zero reference to tracking and which closely destroyed our robot. For this reason, I'm proposing this behaviour, while using
BEST_EFFORTstrictness, it should be similar to the current approach and however, with theSTRICTstrictness, if one of them fails to activate, then just deactivate all of the group.I'll need to handle the same situation when it happens in the
updatecycle, that I'll do it in a different PRThis is an automatic backport of pull request #2669 done by Mergify.