Add --namespace argument to launch command. #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fujitatomoya
approved these changes
Jan 24, 2025
|
@StefanFabian could you please follow up with adding tests? |
|
@StefanFabian, friendly ping |
|
I'm sorry, but we are preparing for a robotics competition in the second week of March, and I don't have any time to invest here until after the competition. |
kramer-sim
force-pushed
the
rolling
branch
2 times, most recently
from
d3b1ca1 to
0ea4d94
Compare
StefanFabian
force-pushed
the
rolling
branch
2 times, most recently
from
0e09968 to
35a832b
Compare
|
@kramer-sim was nice enough to add a test case. Does this work for you? @Yadunund @audrow |
|
@Mergifyio rebase |
…aunching a launch file. Signed-off-by: Stefan Fabian <[email protected]> Signed-off-by: Markus Kramer <[email protected]>
Signed-off-by: Markus Kramer <[email protected]>
✅ Branch has been successfully rebased |
|
Pulls: #433
|
fujitatomoya
requested changes
Apr 11, 2025
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() |
There was a problem hiding this comment.
missing last line feed detected by github.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for pushing a namespace when launching a launch file.