Modify the process for seg.closed & Use of formalised uniform byte units & Modify the description of the openSegmentFile function #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NEMOlv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR contains a three-part modification.
PART 1：Modify the Remove & Close function for segment.go
I think the "seg.closed" for segment files should be set to "false" after calling "seg.fd.Close()". To avoid the case where closing the segment file fails, but the "seg.closed" is set to true.
PART 2：Use of formalised uniform byte units
Just change “GB” to “1 * GB” when using byte constants. This has the advantage that byte constants can be used as units.
PART 3：Modify the description of the openSegmentFile function for segment.go
From the wal.go, it looks like openSegmentFile is used to open both new and old segment file. Simply change "openSegmentFile a new segment file." to "openSegmentFile open a segment file."