Skip to content

Modify the process for seg.closed & Use of formalised uniform byte units & Modify the description of the openSegmentFile function #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NEMOlv wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Modify the process for seg.closed & Use of formalised uniform byte units & Modify the description of the openSegmentFile function #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dbced72
Modify the Remove function for segment
NEMOlv Apr 20, 2025
917e886
formalised uniformity
NEMOlv Apr 20, 2025
e39e66c
modify Close function for segment
NEMOlv Apr 20, 2025
7eee3b8
Modify the description of the openSegmentFile function
NEMOlv Apr 26, 2025
1d7ad7e
Modify the description of the openSegmentFile function
NEMOlv Apr 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion options.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const (

var DefaultOptions = Options{
DirPath: os.TempDir(),
SegmentSize: GB,
SegmentSize: 1 * GB,
SegmentFileExt: ".SEG",
Sync: false,
BytesPerSync: 0,
Expand Down
10 changes: 6 additions & 4 deletions segment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func putBuffer(buf []byte) {
blockPool.Put(buf)
}

// openSegmentFile a new segment file.
// openSegmentFile open a segment file.
func openSegmentFile(dirPath, extName string, id uint32) (*segment, error) {
fd, err := os.OpenFile(
SegmentFileName(dirPath, extName, id),
Expand Down Expand Up @@ -154,10 +154,10 @@ func (seg *segment) Sync() error {
// Remove removes the segment file.
func (seg *segment) Remove() error {
if !seg.closed {
seg.closed = true
if err := seg.fd.Close(); err != nil {
return err
}
seg.closed = true
}

return os.Remove(seg.fd.Name())
Expand All @@ -168,9 +168,11 @@ func (seg *segment) Close() error {
if seg.closed {
return nil
}

if err := seg.fd.Close(); err != nil {
return err
}
seg.closed = true
return seg.fd.Close()
return nil
}

// Size returns the size of the segment file.
Expand Down