♻️ Reduce duplication in normalizing search args #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevans
force-pushed
the
search-refactor-normalize-args
branch
from
0979762
to
cb444ff
Compare
The exact same `RawData` code was used by `search_internal`, `sort_internal`, and `thread_internal`. This pulls that logic into `normalize_searching_criteria`.
nevans
force-pushed
the
search-refactor-normalize-args
branch
from
cb444ff
to
3696dcc
Compare
Forward all `#search` and `#uid_search` arguments to `#search_internal`. This simplifies future changes to search parameters.
nevans
force-pushed
the
search-refactor-normalize-args
branch
from
3696dcc
to
8323ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be have identical behavior to before the refactoring.