Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Reduce duplication in normalizing search args #348

Merged
merged 3 commits into from
Nov 8, 2024
Merged

♻️ Reduce duplication in normalizing search args #348

merged 3 commits into from
Nov 8, 2024

Commits on Nov 7, 2024

  1. ♻️ De-dup code in normalize_searching_criteria 

    The exact same `RawData` code was used by `search_internal`,
`sort_internal`, and `thread_internal`.  This pulls that logic into
`normalize_searching_criteria`.
    @nevans
    nevans committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a86ec0a View commit details
    Browse the repository at this point in the history

  2. ♻️ Simplify CHARSET args in search_internal

    @nevans
    nevans committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    a90782d View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. ♻️ Forward all search/uid_search arguments 

    Forward all `#search` and `#uid_search` arguments to `#search_internal`.
This simplifies future changes to search parameters.
    @nevans
    nevans committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8323ce3 View commit details
    Browse the repository at this point in the history