Skip to content

Add hyperlink button to WYSIWYG toolbar #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add hyperlink button to WYSIWYG toolbar #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/javascript/controllers/editor_controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class extends Controller {
toolbar: 'undo redo | formatselect | ' +
' bold italic backcolor | alignleft aligncenter ' +
' alignright alignjustify | bullist numlist outdent indent | ' +
' removeformat | image code | help',
' removeformat | image link code | help',
valid_elements: '*[*]',
forced_root_block : '',
images_upload_url: '/image_uploads',
Expand Down
22 changes: 22 additions & 0 deletions spec/features/website/page_management_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,4 +192,26 @@
expected_content = indented_html.gsub(initial_text, "#{initial_text}#{added_text}")
expect(Page.last.unpublished_body).to eq(expected_content)
end

scenario "Organizer can add a hyperlink from WYSIWYG editor", js: true do
login_as(organizer)
home_page = create(:page)
url = "http://example.com/resource/1"

visit edit_event_staff_page_path(event, home_page)
click_on('WYSIWYG')
click_on('More...')
click_on('Insert/edit link')

fill_in("URL", with: url)
within('.tox-dialog__footer') { click_on("Save") }
click_on("Save")

accept_confirm { click_on('Publish') }
click_on("View")

expect(page).to have_content(url)
click_on(url)
expect(page).to have_current_path(url, url: true)
end
end