Update to Rust edition 2024

[romancardenas]

No description provided.

[romancardenas]

Looks like we need to update all the crates at once... I will keep doing this when I have time

[romancardenas]

@rmsyn I think it is done. The only test failing is a nightly clippy lint that is still unstable.

[rmsyn]

@rmsyn I think it is done. The only test failing is a nightly clippy lint that is still unstable.

Looks like I can't comment on the offending code, because you didn't make edits to it. Here is my suggestion:

    // riscv-rt/macros/src/lib.rs:91
    #[cfg(feature = "u-boot")]
    if let Some(argument) = f.sig.inputs.get(0) {
        if let Some(message) = check_argument_type(argument, "c_int") {
            return message;
        }
    }
    // instead do
    #[cfg(feature = "u-boot")]
    if let Some(message) = f.sig.inputs.get(0).and_then(|argument| check_argument_type(argument, "c_int")) {
        return message;
    }

    // same as above
    #[cfg(feature = "u-boot")]
    if let Some(argument) = f.sig.inputs.get(1) {
        if let Some(message) = check_argument_type(argument, "*const *const c_char") {
            return message;
        }
    }
    // should be
    #[cfg(feature = "u-boot")]
    if let Some(message) = f.sig.inputs.get(1).and_then(|argument| check_argument_type(argument, "*const *const c_char")) {
            return message;
    }

Edit: here is a branch with formatted changes: https://github.com/rust-embedded/riscv/compare/edition-2024...rmsyn:riscv:edition-2024-lint-fixes?expand=1

[rmsyn]

@romancardenas fixed the lints in #301

[romancardenas]

Please, point to this branch in this PR and I will merge it. I think we should leave this PR updated and ready to merge as soon as we decide to go with edition 2024

[rmsyn]

as soon as we decide to go with edition 2024

After the discussion in today's meeting about updating svd2rust to edition 2024, I think the same arguments apply to the riscv crates, right? Since if riscv crates go to edition 2024, that would force svd2rust to update as well.

Linking the svd2rust discussion for tracking purposes: rust-embedded/svd2rust#933 (comment)

[romancardenas]

Yep, we can leave this PR open and updated to upgrade to edition 2024 whenever the WG decides it is worth it.

[github-actions]

This PR is being prevented from merging because it presents one of the blocking labels: work in progress, do not merge.