Skip to content

Install doctoc from a lockfile - #3507

Merged
emilio merged 1 commit into
rust-lang:mainfrom
Sandijigs:doctoc-lockfile
Oct 5, 2026
Merged

emilio merged 1 commit into
rust-lang:mainfrom
Sandijigs:doctoc-lockfile

Conversation

@Sandijigs

Copy link
Copy Markdown
Contributor

The bump-version workflow and the release steps in CONTRIBUTING.md both run npm install doctoc, which pulls whatever version is newest at the time. This PR adds a package.json and package-lock.json and switches both to npm ci, so doctoc is installed from the lockfile instead. Since npm ci doesn't create or modify those files, the .gitignore entries that were hiding them aren't needed anymore.

This is part of getting zizmor's adhoc-packages audit enabled across rust-lang repos, tracked in rust-lang/crabwatch#48.

@emilio emilio left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good though I've wanted to replace / remove doctoc for a while...

View changes since this review

@emilio

emilio commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Thanks!

@emilio
emilio added this pull request to the merge queue Oct 5, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 5, 2026
@emilio

emilio commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

The failure is not your fault, #3510 hits the same thing. will merge once I sort that out, sorry!

@emilio
emilio added this pull request to the merge queue Oct 5, 2026
Merged via the queue into rust-lang:main with commit 3d7ec57 Oct 5, 2026
52 checks passed
@rustbot rustbot mentioned this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants