Update offload test and verify that tgt_(un)register_lib have the right type #150426
+40
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 29, 2025
add has_offload/needs-offload to the test infra unblocks: rust-lang#150426 Mostly copied from rust-lang#131044 lmk if some of these changes should land separately? r? jieyouxu
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Dec 29, 2025
add has_offload/needs-offload to the test infra unblocks: rust-lang#150426 Mostly copied from rust-lang#131044 lmk if some of these changes should land separately? r? jieyouxu
rust-timer
added a commit
that referenced
this pull request
Dec 29, 2025
Member
Author
|
@bors2 try aarch64-gnu-llvm-20-1 |
Contributor
|
Unknown argument "aarch64-gnu-llvm-20-1". Run |
ZuseZ4
force-pushed
the
offload-register-lib
branch
from
2341687 to
ef942ba
Compare
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
removed
the
S-waiting-on-author
ZuseZ4
force-pushed
the
offload-register-lib
branch
from
ef942ba to
dbd1f05
Compare
Contributor
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. |
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Jan 2, 2026
add has_offload/needs-offload to the test infra unblocks: rust-lang/rust#150426 Mostly copied from rust-lang/rust#131044 lmk if some of these changes should land separately? r? jieyouxu
Collaborator
|
☔ The latest upstream changes (presumably #150606) made this pull request unmergeable. Please resolve the merge conflicts. |
davidtwco
approved these changes
Jan 4, 2026
ZuseZ4
force-pushed
the
offload-register-lib
branch
from
dbd1f05 to
fa584fa
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
We still lack some infra to run this code in CI, but it has been verified locally on AMD APUs/GPUs and an NVIDIA GPU. @bors r=davidtwco rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jan 4, 2026
Rollup of 3 pull requests Successful merges: - #149681 (resolve: Split `Scope::Module` into two scopes for non-glob and glob bindings ) - #150426 (Update offload test and verify that tgt_(un)register_lib have the right type) - #150678 (relate.rs: tiny cleanup: eliminate temp vars) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Jan 5, 2026
Rollup merge of #150426 - ZuseZ4:offload-register-lib, r=davidtwco Update offload test and verify that tgt_(un)register_lib have the right type Apparently, we weren't running offload tests when Enzyme wasn't built. Time to fix that. Also adds a test mode which generates the host IR, but does not expect device IR/artifacts. This way, we don't have to handle artifacts and paths in our tests. Also removes some outdated documentation. cc `@Kevinsala,` `@Sa4dUs` closes: #150415 ~~blocked on `needs-offload` infrastructure landing in #150427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, we weren't running offload tests when Enzyme wasn't built. Time to fix that.
Also adds a test mode which generates the host IR, but does not expect device IR/artifacts. This way, we don't have to handle artifacts and paths in our tests.
Also removes some outdated documentation.
cc @kevinsala, @Sa4dUs
closes: #150415
blocked onneeds-offloadinfrastructure landing in #150427