-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
add has_offload/needs-offload to the test infra #150427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Some changes occurred in src/tools/compiletest cc @jieyouxu
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine. Can you document this directive in rustc-dev-guide?
|
@rustbot author |
371201b to
6e0b610
Compare
|
The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes. |
|
Looks like the needs-enzyme flag precedes this list, so I've added it in a second commit as well. |
|
Thanks |
add has_offload/needs-offload to the test infra unblocks: rust-lang#150426 Mostly copied from rust-lang#131044 lmk if some of these changes should land separately? r? jieyouxu
Rollup of 6 pull requests Successful merges: - #150108 (Offload: Build offload as a single Step) - #150262 (slice iter cleanup: replace checked_sub with saturating_sub) - #150427 (add has_offload/needs-offload to the test infra) - #150458 (fix running stdlib doctests in Miri in CI) - #150477 (Fix enum variant suggestion consuming trailing parenthesis) - #150478 (Fix new bors config) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 6 pull requests Successful merges: - rust-lang/rust#150108 (Offload: Build offload as a single Step) - rust-lang/rust#150262 (slice iter cleanup: replace checked_sub with saturating_sub) - rust-lang/rust#150427 (add has_offload/needs-offload to the test infra) - rust-lang/rust#150458 (fix running stdlib doctests in Miri in CI) - rust-lang/rust#150477 (Fix enum variant suggestion consuming trailing parenthesis) - rust-lang/rust#150478 (Fix new bors config) r? `@ghost` `@rustbot` modify labels: rollup
…idtwco Update offload test and verify that tgt_(un)register_lib have the right type Apparently, we weren't running offload tests when Enzyme wasn't built. Time to fix that. Also adds a test mode which generates the host IR, but does not expect device IR/artifacts. This way, we don't have to handle artifacts and paths in our tests. Also removes some outdated documentation. cc `@Kevinsala,` `@Sa4dUs` closes: rust-lang#150415 ~~blocked on `needs-offload` infrastructure landing in rust-lang#150427
Rollup merge of #150426 - ZuseZ4:offload-register-lib, r=davidtwco Update offload test and verify that tgt_(un)register_lib have the right type Apparently, we weren't running offload tests when Enzyme wasn't built. Time to fix that. Also adds a test mode which generates the host IR, but does not expect device IR/artifacts. This way, we don't have to handle artifacts and paths in our tests. Also removes some outdated documentation. cc `@Kevinsala,` `@Sa4dUs` closes: #150415 ~~blocked on `needs-offload` infrastructure landing in #150427
unblocks: #150426
Mostly copied from #131044
lmk if some of these changes should land separately?
r? jieyouxu