Skip to content

Conversation

@ZuseZ4
Copy link
Member

@ZuseZ4 ZuseZ4 commented Dec 27, 2025

unblocks: #150426

Mostly copied from #131044
lmk if some of these changes should land separately?

r? jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@ZuseZ4 ZuseZ4 removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 27, 2025
@ZuseZ4 ZuseZ4 marked this pull request as ready for review December 27, 2025 12:28
@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2025

Some changes occurred in src/tools/compiletest

cc @jieyouxu

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 27, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Can you document this directive in rustc-dev-guide?

View changes since this review

@jieyouxu
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 29, 2025

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@rustbot rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Dec 29, 2025
@ZuseZ4
Copy link
Member Author

ZuseZ4 commented Dec 29, 2025

Looks like the needs-enzyme flag precedes this list, so I've added it in a second commit as well.
@rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 29, 2025
@jieyouxu
Copy link
Member

Thanks
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 29, 2025

📌 Commit 6e0b610 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 29, 2025
add has_offload/needs-offload to the test infra

unblocks: rust-lang#150426

Mostly copied from rust-lang#131044
lmk if some of these changes should land separately?

r? jieyouxu
bors added a commit that referenced this pull request Dec 29, 2025
Rollup of 6 pull requests

Successful merges:

 - #150108 (Offload: Build offload as a single Step)
 - #150262 (slice iter cleanup: replace checked_sub with saturating_sub)
 - #150427 (add has_offload/needs-offload to the test infra)
 - #150458 (fix running stdlib doctests in Miri in CI)
 - #150477 (Fix enum variant suggestion consuming trailing parenthesis)
 - #150478 (Fix new bors config)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 19907e6 into rust-lang:main Dec 29, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 29, 2025
rust-timer added a commit that referenced this pull request Dec 29, 2025
Rollup merge of #150427 - ZuseZ4:offload-testinfra, r=jieyouxu

add has_offload/needs-offload to the test infra

unblocks: #150426

Mostly copied from #131044
lmk if some of these changes should land separately?

r? jieyouxu
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 2, 2026
Rollup of 6 pull requests

Successful merges:

 - rust-lang/rust#150108 (Offload: Build offload as a single Step)
 - rust-lang/rust#150262 (slice iter cleanup: replace checked_sub with saturating_sub)
 - rust-lang/rust#150427 (add has_offload/needs-offload to the test infra)
 - rust-lang/rust#150458 (fix running stdlib doctests in Miri in CI)
 - rust-lang/rust#150477 (Fix enum variant suggestion consuming trailing parenthesis)
 - rust-lang/rust#150478 (Fix new bors config)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 4, 2026
…idtwco

Update offload test and verify that tgt_(un)register_lib have the right type

Apparently, we weren't running offload tests when Enzyme wasn't built. Time to fix that.
Also adds a test mode which generates the host IR, but does not expect device IR/artifacts. This way, we don't have to handle artifacts and paths in our tests.
Also removes some outdated documentation.

cc `@Kevinsala,` `@Sa4dUs`

closes: rust-lang#150415

~~blocked on `needs-offload` infrastructure landing in rust-lang#150427
rust-timer added a commit that referenced this pull request Jan 5, 2026
Rollup merge of #150426 - ZuseZ4:offload-register-lib, r=davidtwco

Update offload test and verify that tgt_(un)register_lib have the right type

Apparently, we weren't running offload tests when Enzyme wasn't built. Time to fix that.
Also adds a test mode which generates the host IR, but does not expect device IR/artifacts. This way, we don't have to handle artifacts and paths in our tests.
Also removes some outdated documentation.

cc `@Kevinsala,` `@Sa4dUs`

closes: #150415

~~blocked on `needs-offload` infrastructure landing in #150427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants