Port a lot of attributes to the new parser #152364
Open
+564
−288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
9 tasks
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-a-lot
branch
2 times, most recently
from
fc14cd5 to
747e670
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-a-lot
branch
from
747e670 to
643338a
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
@bors r+ rollup=iffy |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 9, 2026
…nBrouwer Port a lot of attributes to the new parser r? @JonathanBrouwer See commits for which attributes
rust-bors
bot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
port-a-lot
branch
from
643338a to
c51cd49
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Contributor
Author
|
@bors rollup |
Contributor
|
@bors p=1 |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…nbrouwer Port a lot of attributes to the new parser r? @JonathanBrouwer See commits for which attributes
Contributor
Author
|
good idea jonathan, ty! |
jdonszelmann
force-pushed
the
port-a-lot
branch
from
c51cd49 to
12dbc1b
Compare
rust-bors
bot
added
S-waiting-on-author
Contributor
|
|
Contributor
Author
|
@bors r=jonathanbrouwer |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…nbrouwer Port a lot of attributes to the new parser r? @JonathanBrouwer See commits for which attributes
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…uwer Rollup of 11 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`) - #152425 (Port #![test_runner] to the attribute parser)
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
Port a lot of attributes to the new parser r? @JonathanBrouwer See commits for which attributes
Contributor
|
⌛ Testing commit 12dbc1b with merge 33f4a3d... Workflow: https://github.com/rust-lang/rust/actions/runs/21863892136 |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 10, 2026
…nbrouwer Port a lot of attributes to the new parser r? @JonathanBrouwer See commits for which attributes
Contributor
|
@bors yield |
Contributor
|
Auto build cancelled. Cancelled workflows: The next pull request likely to be tested is #152437. |
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…uwer Rollup of 10 pull requests Successful merges: - #152364 (Port a lot of attributes to the new parser) - #151954 (Add help message suggesting explicit reference cast for From/TryFrom) - #152148 (Move `impl Interner for TyCtxt` to its own submodule) - #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds) - #152351 (Remove `SubdiagMessage` in favour of the identical `DiagMessage`) - #152417 (Move the needs-drop check for `arena_cache` queries out of macro code) - #150688 (typeck: Make it clearer that `check_pat_lit` only handles literal patterns) - #152293 (Format heterogeneous try blocks) - #152355 (Update documentation of rustc_macros) - #152396 (Uplift `Predicate::allow_normalization` to `rustc_type_ir`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @JonathanBrouwer
See commits for which attributes