Rollup of 10 pull requests #152437

JonathanBrouwer · 2026-02-10T12:00:50Z

Successful merges:

Port a lot of attributes to the new parser #152364 (Port a lot of attributes to the new parser)
Add help message suggesting explicit reference cast for From/TryFrom #151954 (Add help message suggesting explicit reference cast for From/TryFrom)
Move impl Interner for TyCtxt to its own submodule #152148 (Move impl Interner for TyCtxt to its own submodule)
Modernize diagnostic for indeterminate trait object lifetime bounds #152226 (Modernize diagnostic for indeterminate trait object lifetime bounds)
Remove SubdiagMessage in favour of the identical DiagMessage #152351 (Remove SubdiagMessage in favour of the identical DiagMessage)
Move the needs-drop check for arena_cache queries out of macro code #152417 (Move the needs-drop check for arena_cache queries out of macro code)
typeck: Make it clearer that check_pat_lit only handles literal patterns #150688 (typeck: Make it clearer that check_pat_lit only handles literal patterns)
Format heterogeneous try blocks #152293 (Format heterogeneous try blocks)
Update documentation of rustc_macros #152355 (Update documentation of rustc_macros)
Uplift Predicate::allow_normalization to rustc_type_ir #152396 (Uplift Predicate::allow_normalization to rustc_type_ir)

Make fmt check happy

Requiring `fn` in the macro syntax makes it a little more obvious that the macro declares functions with those names, and makes them easier to grep for.

@JonathanBrouwer

…nbrouwer Port a lot of attributes to the new parser r? @JonathanBrouwer See commits for which attributes

…-message, r=eholk Add help message suggesting explicit reference cast for From/TryFrom Closes rust-lang#109829 Improves E0277 diagnostics when a `From` or `TryFrom` implementation is expected, but the provided type is a reference that can be explicitly cast to a type the trait can convert from.

Move `impl Interner for TyCtxt` to its own submodule This impl is several hundred lines of mostly self-contained, mostly boilerplate code that can be extracted out of the dauntingly large `rustc_middle::ty::context` module. - The trait and its impl were introduced by rust-lang#97287. --- There should be no change to compiler behaviour.

…ect-lifetime-diag, r=chenyukang Modernize diagnostic for indeterminate trait object lifetime bounds * remove suggestion from the diagnostic message (bad style, too long) and turn it into a structured suggestion * replace *object type* with *trait object type* since the former is an outdated term

…nnethercote Remove `SubdiagMessage` in favour of the identical `DiagMessage` For rust-lang#151366 Just some more cleanup :) SubdiagMessage is now identical to DiagMessage, so there's no point in having both of them

Move the needs-drop check for `arena_cache` queries out of macro code This is slightly simpler than before, because now the macro only needs to call a single function, and can just unconditionally supply `tcx` and a typed arena. There should be no actual change to compiler behaviour.

…nkov typeck: Make it clearer that `check_pat_lit` only handles literal patterns Nowadays, the `hir::PatExprKind` enum guarantees that “expressions” in patterns can only be paths or literals. `PatExprKind::Path` is already handled by the previous match arm, so we can make this match arm explicitly match on `PatExprKind::Lit` without losing exhaustiveness. There should be no actual change to compiler behaviour.

…mimi Format heterogeneous try blocks The tracking issue for `try_blocks_heterogeneous` is rust-lang#149488. This follows the formatting of homogeneous try blocks (feature `try_blocks`) by considering `try bikeshed <type>` to be the equivalent of `try` (in particular a single "token"). An alternative would be to permit breaking between `bikeshed` and `<type>`, but given that those 2 elements are an explicitly temporary part of the syntax, it doesn't seem worth it. There also doesn't seem to be any existing precedent breaking between a keyword and a type. It also doesn't seem to be useful in practice, given that the type itself doesn't break (which is how it works for the return type of closures) and has more chances to dominate the length in case a break is necessary. Happy to adapt anything in case this formatting is not optimal. The test is also copied from homogeneous try blocks with 2 additional test cases to demonstrate the behavior with long types. See [#t-lang > try blocks @ 💬](https://rust-lang.zulipchat.com/#narrow/channel/213817-t-lang/topic/try.20blocks/near/572387493) for context.

…r=nnethercote Update documentation of rustc_macros Update the docs to reflect the changes in rust-lang#151366

JonathanBrouwer · 2026-02-10T12:03:56Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-10T12:03:59Z

📌 Commit 083622c has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-02-10T16:16:23Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 4h 11m 48s
Pushing d00ba92 to main...

github-actions · 2026-02-10T16:19:09Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing f21b4c0 (parent) -> d00ba92 (this PR)

Test differences

Show 304 test diffs

Stage 1

[ui] tests/ui/traits/explicit-reference-cast.rs: [missing] -> pass (J0)

Stage 2

[ui] tests/ui/traits/explicit-reference-cast.rs: [missing] -> pass (J1)

Additionally, 302 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard d00ba922591daa3d0a8b0f3cdf54c610097c24ea --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 1h 28m -> 2h 27m (+66.0%)
dist-x86_64-apple: 2h 8m -> 2h 52m (+34.9%)
aarch64-msvc-2: 1h 55m -> 1h 38m (-14.5%)
x86_64-gnu-llvm-20-1: 1h 7m -> 1h 15m (+12.0%)
dist-aarch64-apple: 2h 43m -> 3h (+10.6%)
aarch64-msvc-1: 2h 5m -> 1h 52m (-10.5%)
x86_64-msvc-ext1: 2h 4m -> 2h 16m (+9.8%)
dist-loongarch64-musl: 1h 44m -> 1h 53m (+9.0%)
dist-loongarch64-linux: 1h 41m -> 1h 49m (+8.8%)
test-various: 2h 5m -> 1h 54m (-8.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-10T16:58:42Z

Finished benchmarking commit (d00ba92): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.1%	[-0.1%, -0.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.3%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.7%, 0.7%]	1
Regressions ❌ (secondary)	3.3%	[1.8%, 4.9%]	2
Improvements ✅ (primary)	-1.4%	[-1.4%, -1.4%]	1
Improvements ✅ (secondary)	-1.7%	[-2.2%, -1.2%]	2
All ❌✅ (primary)	-0.3%	[-1.4%, 0.7%]	2

Cycles

Results (secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[2.3%, 3.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.7%	[-2.7%, -2.7%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 477.06s -> 474.836s (-0.47%)
Artifact size: 398.00 MiB -> 398.02 MiB (0.01%)

Muhtasim-Rasheed and others added 30 commits February 1, 2026 19:06

Add help message suggesting explicit reference cast for From/TryFrom

ac159dd

Make fmt check happy

Modernize diagnostic for indeterminate trait object lifetime bounds

dc24aae

Format heterogeneous try blocks

03dcd99

improve tests

d5c6866

Make it clearer that check_pat_lit only handles literal patterns

90fd768

Don't import TyCtxt from crate::ty::context

91d47a5

Move impl Interner for TyCtxt to its own submodule

4234d2d

Indicate that bidirectional_lang_item_map! declares functions

b7bfb76

Requiring `fn` in the macro syntax makes it a little more obvious that the macro declares functions with those names, and makes them easier to grep for.

Move the needs-drop check for arena_cache queries out of macro code

4dc82e9

Uplift Predicate::allow_normalization to rustc_type_ir

20f65fc

Port rustc_expected_cgu_reuse to the new attribute parser

00fef81

Port rustc_deprecated_safe_2024 to the new attribute parser

9cc2924

Port rustc_conversion_suggestion to the new attribute parser

9d10b2f

Port rustc_capture_analysis to the new attribute parser

a17eb93

Remove SubdiagMessage in favour of the identical DiagMessage

ea36128

Port rustc_never_type_options to the new attribute parser

954f483

Update documentation of rustc_macros

2377d35

Port rustc_trivial_field_reads to the new attribute parser

f4c135f

Port rustc_no_mir_inline to the new attribute parser

eab26e3

Make rustc_object_lifetime_default use NoArgsAttributeParser

fe7530c

remove 'static in many places

12dbc1b

Rollup merge of rust-lang#152364 - jdonszelmann:port-a-lot, r=jonatha…

935904f

…nbrouwer Port a lot of attributes to the new parser r? @JonathanBrouwer See commits for which attributes

Rollup merge of rust-lang#152355 - JonathanBrouwer:update-macro-doc, …

faa1580

…r=nnethercote Update documentation of rustc_macros Update the docs to reflect the changes in rust-lang#151366

JonathanBrouwer mentioned this pull request Feb 10, 2026

Rollup of 11 pull requests #152430

Closed

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 10, 2026

rust-bors bot mentioned this pull request Feb 10, 2026

Port a lot of attributes to the new parser #152364

Merged

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 10, 2026

rust-bors bot merged commit d00ba92 into rust-lang:main Feb 10, 2026
12 checks passed

rustbot added this to the 1.95.0 milestone Feb 10, 2026

rust-bors bot mentioned this pull request Feb 10, 2026

Make trait refs & assoc ty paths properly induce trait object lifetime defaults #129543

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #152437

Rollup of 10 pull requests #152437

JonathanBrouwer commented Feb 10, 2026

Uh oh!

JonathanBrouwer commented Feb 10, 2026

Uh oh!

rust-bors bot commented Feb 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 10, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Rollup of 10 pull requests #152437

Rollup of 10 pull requests #152437

Conversation

JonathanBrouwer commented Feb 10, 2026

Uh oh!

JonathanBrouwer commented Feb 10, 2026

Uh oh!

rust-bors bot commented Feb 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 10, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 10, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Feb 10, 2026

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants