Rollup of 15 pull requests by JonathanBrouwer · Pull Request #153047 · rust-lang/rust

JonathanBrouwer · 2026-02-24T13:42:02Z

Successful merges:

Neon fast path for str::contains #152176 (Neon fast path for str::contains)
std: move exit out of PAL #152657 (std: move exit out of PAL)
Streamline QueryVTableUnerased into GetQueryVTable #152841 (Streamline QueryVTableUnerased into GetQueryVTable)
Skip tidy in PR CI jobs not dedicated to running tidy #152845 (Skip tidy in PR CI jobs not dedicated to running tidy)
Add optional json logging #152897 (Add optional json logging)
Remove rustc_feedable_queries and define_feedable macros. #153009 (Remove rustc_feedable_queries and define_feedable macros.)
Port diagnostic attributes #151558 (Port diagnostic attributes)
mGCA: Enforce WF element types for array valtrees #152492 (mGCA: Enforce WF element types for array valtrees)
Fix async drop glue MIR bug #152888 (Fix async drop glue MIR bug)
Port #[register_tool] to the new attribute system #152988 (Port #[register_tool] to the new attribute system)
unused_must_use lint improvements #153018 (unused_must_use lint improvements)
Update books #153023 (Update books)
Clarify how "ensure" queries check whether they can skip execution #153033 (Clarify how "ensure" queries check whether they can skip execution)
fix error on missing value for -C flags #153043 (fix error on missing value for -C flags)
rustc-dev-guide subtree update #153045 (rustc-dev-guide subtree update)

Failed merges:

Fix attribute parser and kind names. #153032 (Fix attribute parser and kind names.)

r? @ghost

Create a similar rollup

… with tuple arg

This updates the rust-version file to 1396514.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@1396514 Filtered ref: rust-lang/rustc-dev-guide@30addec Upstream diff: rust-lang/rust@44e34e1...1396514 This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

Introduce `@bors squash` command

Most of the commands were specified with `./x`, but three of the commands were using `./x.py` without a clear reason - align with the guide's convention of using `./x`.

rustdoc.md: consistently use `./x` rather than `./x.py`

document 'x' command in nix-dev-shell

Update feature gating link in overview.md

This is both: 1. Redundant, since PR CI has a dedicated `tidy` job 2. A contributor roadblock, because tidy failures block further failures from being revealed. We *only* skip tidy in PR CI and not in Merge CI because tidy in Merge CI will early-cancel *anyway*.

This updates the rust-version file to c78a294.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@c78a294 Filtered ref: rust-lang/rustc-dev-guide@2f61036 Upstream diff: rust-lang/rust@1396514...c78a294 This merge was created using https://github.com/rust-lang/josh-sync.

Rustc pull update

This removes `Suppressed` as a must use cause that could be nested in another (we did not ever return this, but now it's encoded in the types). I also renamed Suppressed->Trvial and added some docs to clear confusion.

…nd `ControlFlow<Uninhabited, T>`

all but one test suite support revisions directive

`rustc_queries!` produces two macros: `rustc_with_all_queries` and `rustc_feedable_queries`. The latter is similar to the former but only includes feedable queries. But feedable queries don't need a separate mechanism because we can identify feedable queries within `define_callbacks!` by just looking for the `feedable` modifier. (That's what we do with every modifier other than `feedable`.) This commit removes the special handling and treats feedable queries like everything else. Note that this commit exposes and fixes a latent doc bug. The doc comment for query `explicit_predicates_of` links to `Self::predicates_of`. `explicit_predicates_of` is a feedable query but `predicates_of` is not, so for `TyCtxtFeed` this link is invalid. This wasn't manifesting because `TyCtxtFeed` wasn't getting doc comments attached. It now is, so I changed the link to `TyCtxt::predicates_of`.

JonathanBrouwer · 2026-02-24T14:13:01Z

@bors r+ rollup=never p=5

rust-bors · 2026-02-24T14:13:04Z

📌 Commit b1a17e0 has been approved by JonathanBrouwer

It is now in the queue for this repository.

rust-bors · 2026-02-24T16:15:31Z

☀️ Try build successful (CI)
Build commit: bd73668 (bd736682f31cadda16e576919069f0876d26803e, parent: 0028f344ce9f64766259577c998a1959ca1f6a0b)

rust-bors · 2026-02-24T19:03:19Z

☀️ Test successful - CI
Approved by: JonathanBrouwer
Duration: 4h 26m 31s
Pushing 859951e to main...

github-actions · 2026-02-24T19:06:32Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0028f34 (parent) -> 859951e (this PR)

Test differences

Show 102 test diffs

Stage 1

[mir-opt] tests/mir-opt/async_drop_mir_pin.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/array-const-arg-type-mismatch.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/array-with-wrong-tuple-type.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/array_expr_arg_complex.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/invalid-array-in-tuple.rs: [missing] -> pass (J0)
[ui] tests/ui/diagnostic_namespace/on_unimplemented/ignore_unsupported_options_and_continue_to_use_fallback.rs: pass -> [missing] (J0)

Stage 2

[ui] tests/ui/const-generics/mgca/array-const-arg-type-mismatch.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/array-with-wrong-tuple-type.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/array_expr_arg_complex.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/invalid-array-in-tuple.rs: [missing] -> pass (J1)
[ui] tests/ui/diagnostic_namespace/on_unimplemented/ignore_unsupported_options_and_continue_to_use_fallback.rs: pass -> [missing] (J1)
[mir-opt] tests/mir-opt/async_drop_mir_pin.rs: [missing] -> pass (J2)

Additionally, 90 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 859951e3c7c9d0322c39bad49221937455bdffcd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-apple-various: 1h 38m -> 3h 2m (+85.0%)
dist-aarch64-apple: 2h 32m -> 2h 9m (-15.2%)
pr-check-1: 32m 15s -> 27m 54s (-13.5%)
x86_64-gnu-llvm-21-1: 1h 17m -> 1h 8m (-11.6%)
i686-msvc-2: 2h -> 2h 14m (+11.4%)
aarch64-gnu-llvm-20-2: 46m 52s -> 51m 26s (+9.7%)
dist-x86_64-apple: 3h 1m -> 3h 17m (+8.8%)
aarch64-apple: 4h 41m -> 4h 17m (-8.8%)
test-various: 2h 3m -> 1h 53m (-8.2%)
dist-i686-mingw: 2h 26m -> 2h 38m (+8.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-02-24T19:07:38Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#151558	Port diagnostic attributes	`d8963a84218d35456bfa7a1842159300b06fddf3` (link)
#152176	Neon fast path for str::contains	`a9cc8c1a7241f2bc20f1ca54406494f25a287e00` (link)
#152492	mGCA: Enforce WF element types for array valtrees	`3e4d4ad88446c971ec85b492737732f27b5509e7` (link)
#152657	std: move `exit` out of PAL	`9693148a49a58fada8b1b3189040751414a22ab0` (link)
#152841	Streamline `QueryVTableUnerased` into `GetQueryVTable`	`e9b188f54cd18492eb16f3f01be02da92192c4bd` (link)
#152845	Skip `tidy` in PR CI jobs not dedicated to running `tidy`	`db3cf21bb4198951893a3f73d2300d399133362d` (link)
#152888	Fix async drop glue MIR bug	`cfa2560b90debc019ebef8c26285045e5270e513` (link)
#152897	Add optional json logging	`21894ca4864d6353ea013241f21f7d9f4526d1e1` (link)
#152988	Port `#[register_tool]` to the new attribute system	`fcdc5dd7b5fbee7728719a239dddfe31dc211784` (link)
#153009	Remove `rustc_feedable_queries` and `define_feedable` macro…	`69dc5fbcd14b3829884bbad1d5e023a3a141d590` (link)
#153018	`unused_must_use` lint improvements	`d8e753a7cdfad529a493b3a7b1bfa5ec1c535d8a` (link)
#153023	Update books	`1fd164f90930ce3f37e35ffd556f686ef7849862` (link)
#153033	Clarify how "ensure" queries check whether they can skip ex…	`31acd2afd81fe91c99d48335908cd8f14562e17b` (link)
#153043	fix error on missing value for -C flags	`8890471d91ed9afb0dce3fe494aa9e505aa50a37` (link)
#153045	rustc-dev-guide subtree update	`4bb05286cf5e0f3f78b3ff28b2c5c91fea8cde5a` (link)

previous master: 0028f344ce

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2026-02-24T19:44:39Z

Finished benchmarking commit (859951e): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-0.1%	[-0.1%, -0.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-0.1%, -0.1%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.8%, secondary 3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.1%	[3.1%, 3.1%]	1
Improvements ✅ (primary)	-2.8%	[-2.8%, -2.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.8%	[-2.8%, -2.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 479.414s -> 481s (0.33%)
Artifact size: 395.72 MiB -> 397.83 MiB (0.53%)

JamieCunliffe and others added 30 commits January 27, 2026 16:18

Neon fast path for str::contains

011d95b

require array const params to have correctly typed elems

1d39a91

tests to check if ValTree checks elems recursively + check array expr…

68c705d

… with tuple arg

move array test to diff file

7030be6

Prepare for merging from rust-lang/rust

7172f7e

This updates the rust-version file to 1396514.

Merge pull request rust-lang#2777 from rust-lang/rustc-pull

ca4ff29

Rustc pull update

Introduce @bors squash command

508cadb

Merge pull request rust-lang#2779 from reddevilmidzy/squash

7b38904

Introduce `@bors squash` command

rustdoc.md: consistently use ./x rather than ./x.py

3e47b01

Most of the commands were specified with `./x`, but three of the commands were using `./x.py` without a clear reason - align with the guide's convention of using `./x`.

Merge pull request rust-lang#2780 from DanielEScherzer/patch-1

cd6103b

rustdoc.md: consistently use `./x` rather than `./x.py`

document 'x' command in nix-dev-shell

f19de24

Merge pull request rust-lang#2781 from BennoLossin/patch-1

4479ca7

document 'x' command in nix-dev-shell

Update feature gating link in overview.md

d5065ee

Merge pull request rust-lang#2782 from rust-lang/feature-gate

99619bc

Update feature gating link in overview.md

Prepare for merging from rust-lang/rust

1e4faad

This updates the rust-version file to c78a294.

Merge pull request rust-lang#2783 from rust-lang/rustc-pull

d1f5c6a

Rustc pull update

std: move exit out of PAL

d05eb78

move must_use lint to a separate file

b0050c2

make is_ty_must_use public

c6ae0a9

must_use: internal doc improvements

696a105

must_use: make the check for trivial types cleaner

b2cc4d5

This removes `Suppressed` as a must use cause that could be nested in another (we did not ever return this, but now it's encoded in the types). I also renamed Suppressed->Trvial and added some docs to clear confusion.

must_use: drive-by-cleanup

ae1e2c6

add a flag to is_ty_must_use to simplify Result<T, Uninhabited> a…

1b97e9b

…nd `ControlFlow<Uninhabited, T>`

Update books

a67baaa

all but one test suite support revisions directive

a2bb73c

Merge pull request rust-lang#2749 from rust-lang/date-check-compiletest

7ec895b

all but one test suite support revisions directive

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2026

rust-bors bot merged commit 859951e into rust-lang:main Feb 24, 2026
13 checks passed

rustbot added this to the 1.95.0 milestone Feb 24, 2026

This was referenced Feb 24, 2026

Improve how QueryCache/QueryState/QueryEngine are stored #152835

Merged

Fix attribute parser and kind names. #153032

Merged

Migration of LintDiagnostic - part 3 #153051

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Comments

Rollup of 15 pull requests#153047

Rollup of 15 pull requests#153047
rust-bors[bot] merged 125 commits intorust-lang:mainfrom
JonathanBrouwer:rollup-l4iF4ru

JonathanBrouwer commented Feb 24, 2026

Uh oh!

JonathanBrouwer commented Feb 24, 2026

Uh oh!

rust-bors bot commented Feb 24, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 24, 2026

Uh oh!

rust-bors bot commented Feb 24, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Feb 24, 2026

Uh oh!

rust-timer commented Feb 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

Uh oh!

Comments

Conversation

JonathanBrouwer commented Feb 24, 2026

Uh oh!

JonathanBrouwer commented Feb 24, 2026

Uh oh!

rust-bors bot commented Feb 24, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Feb 24, 2026

Uh oh!

rust-bors bot commented Feb 24, 2026

Uh oh!

Uh oh!

github-actions bot commented Feb 24, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Feb 24, 2026

Uh oh!

rust-timer commented Feb 24, 2026

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants