Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript issues in Destinations and CLI #2725

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

sayan-das-in
Copy link
Contributor

This PR aims to fix minor type issues for Node version upgrade with typescript 4.9.5 and simplifies this PR.

Testing

Tested locally with unit tests.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

varadarajan-tw
varadarajan-tw previously approved these changes Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (25a5473) to head (f55db48).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/commands/generate/action.ts 0.00% 4 Missing ⚠️
packages/cli/src/commands/init.ts 0.00% 3 Missing ⚠️
...re-experimentation-actions/trackEvent/functions.ts 33.33% 2 Missing ⚠️
...src/destinations/intercom/identifyContact/index.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2725      +/-   ##
==========================================
- Coverage   79.07%   78.56%   -0.52%     
==========================================
  Files        1089     1036      -53     
  Lines       21534    18767    -2767     
  Branches     4330     3562     -768     
==========================================
- Hits        17029    14744    -2285     
+ Misses       3298     2822     -476     
+ Partials     1207     1201       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

varadarajan-tw
varadarajan-tw previously approved these changes Feb 5, 2025
@sayan-das-in sayan-das-in merged commit 56e9fc2 into main Feb 5, 2025
12 of 14 checks passed
@sayan-das-in sayan-das-in deleted the typescript-fixes branch February 5, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants