Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript issues in Destinations and CLI #2725

Merged
merged 2 commits into from
Feb 5, 2025
+21 −17

Updated DV360 error type

f55db48
Select commit
Loading
Failed to load commit list.
Merged

Fix typescript issues in Destinations and CLI #2725

Updated DV360 error type
f55db48
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Feb 5, 2025 in 0s

78.56% (-0.52%) compared to 25a5473

View this Pull Request on Codecov

78.56% (-0.52%) compared to 25a5473

Details

Codecov Report

Attention: Patch coverage is 41.17647% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.56%. Comparing base (25a5473) to head (f55db48).

Files with missing lines Patch % Lines
packages/cli/src/commands/generate/action.ts 0.00% 4 Missing ⚠️
packages/cli/src/commands/init.ts 0.00% 3 Missing ⚠️
...re-experimentation-actions/trackEvent/functions.ts 33.33% 2 Missing ⚠️
...src/destinations/intercom/identifyContact/index.ts 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2725      +/-   ##
==========================================
- Coverage   79.07%   78.56%   -0.52%     
==========================================
  Files        1089     1036      -53     
  Lines       21534    18767    -2767     
  Branches     4330     3562     -768     
==========================================
- Hits        17029    14744    -2285     
+ Misses       3298     2822     -476     
+ Partials     1207     1201       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov