fix tutorial #566
Merged
fix tutorial #566
+760
−733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
… code altogether)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of fixes for IMA.js tutorial. Lots of links were dead. The typescript code snippets didn't always worked and were written for functional components. That would be great if the tutorial was written that way as a whole, which is not. (JS snippets were for class components as well as the description/explanation of each thing, so the TS code didn't correspond with the written word.) I deleted all the functional stuff, therefore the tutorial is now doable in JS as well as in TS and in the end there should be only TS-related differences.
It would be great to rewrite the tutorial for functional components but that would mean to change lot more than conde snippets, which is something I am not able to do right now.