Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tutorial #566

Merged
merged 14 commits into from
Mar 13, 2025
+760 −733
Merged

fix tutorial #566

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b399377
fix tutorial: default export to named export
Rayus7 Apr 5, 2024
6c0c287
Merge branch 'master' into fix-tutorial
Rayus7 Feb 6, 2025
9b94915
fix links, fix TS snippets (it should be JS only typed, not different…
Rayus7 Feb 11, 2025
ed8adbc
tutorial fixes
Rayus7 Mar 3, 2025
4c82ee4
fetchig-data tutorial fixes
Rayus7 Mar 5, 2025
4039a56
writing-posts fixes, better indentation, fix links
Rayus7 Mar 6, 2025
f05a558
final-polish in process
Rayus7 Mar 6, 2025
491f81e
fix final-polish
Rayus7 Mar 7, 2025
f21c144
fix code snippets indentation
Rayus7 Mar 11, 2025
14f35b7
fix code snippets indentation
Rayus7 Mar 11, 2025
872e748
fix indentation
Rayus7 Mar 13, 2025
c71c8e6
fix indentation
Rayus7 Mar 13, 2025
e5c85ee
fix indentation
Rayus7 Mar 13, 2025
18460b4
fix indentation
Rayus7 Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/basic-features/controller-lifecycle.md
View file
Original file line number Diff line number Diff line change
@@ -79,7 +79,7 @@ async load() {
## `setMetaParams()` *@server/client*

Callback used to configure the meta attribute manager. The method is
called after the the controller's state has been patched with the all
called after the controller's state has been patched with the all
loaded resources from the [`load()`](#load-serverclient) method and the view has been rendered.

`setMetaParams()` method receives following arguments:
Loading

Unchanged files with check annotations Beta

View file
packages/devtools/src/models/__tests__/TabConnectionSpec.js
});
// FIXME memory leak
// describe('_settingsCallback', () => {

Check warning on line 592 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// beforeEach(() => {
// instance._settingsListener = jest.fn();
// });
// it('should not do anything if action is not settings action', () => {

Check warning on line 597 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// instance._settingsCallback({
// action: Actions.POPUP,
// payload: { enabled: true },
// expect(instance._settingsListener.mock.calls).toHaveLength(0);
// });
// it('should call settings listener with enabled value', () => {

Check warning on line 606 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// instance._settingsCallback({
// action: Actions.SETTINGS,
// payload: { enabled: true },
// });
// });
// describe('_aliveCallback', () => {

Check warning on line 617 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// beforeEach(() => {
// instance = new TabConnection(tabId);
// jest.spyOn(instance, '_reviveDevtools').mockImplementation();
// utils.setIcon.mockReset();
// });
// it('should save state on action detecting', () => {

Check warning on line 628 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// expect(instance.state).toBe(State.RELOAD);
// instance._aliveCallback({
// expect(instance.state).toBe(State.DETECTING);
// });
// it('should save state on action dead', () => {

Check warning on line 639 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// expect(instance.state).toBe(State.RELOAD);
// instance._aliveCallback({
// expect(instance.state).toBe(State.DEAD);
// });
// it('should save state on action alive and set payload to appData', () => {

Check warning on line 650 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// expect(instance.state).toBe(State.RELOAD);
// instance._aliveCallback({
// expect(instance.appData).toStrictEqual({ version: 0 });
// });
// it('should set alive icon on current tab on alive', () => {

Check warning on line 662 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// instance._aliveCallback({
// action: Actions.ALIVE,
// payload: { version: 0 },
// expect(utils.setIcon.mock.calls[0][1]).toBe(instance.tabId);
// });
// it("should revive devtools if it's registered", () => {

Check warning on line 673 in packages/devtools/src/models/__tests__/TabConnectionSpec.js

GitHub Actions / CI 

Some tests seem to be commented
// instance._aliveCallback({
// action: Actions.ALIVE,
// payload: { version: 0 },
View file
packages/core/transform/transformUtils/__tests__/importsSpec.js
/**
* @todo Update removeUnusedPackageImports method to support this behavior
*/
it.skip('should remove only unused imports if multiple imports from single package are used', () => {

Check warning on line 88 in packages/core/transform/transformUtils/__tests__/importsSpec.js

GitHub Actions / CI 

Disabled test
ast = j(`
import Sample, { UsedModule, UnusedModule } from 'sample-package';