Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the aria-expanded attribute to the side panel's collapse toggle button to improve accessibility. However, the current implementation relies on a state signal that does not account for temporary expansion modes, such as mobile drawers or hover-to-expand, which could result in inaccurate accessibility information for screen readers.
projects/element-ng/side-panel/si-side-panel-content.component.html
Outdated
Show resolved
Hide resolved
akashsonune
force-pushed
the
fix/side-panel-aria-expanded
branch
from
05ba472 to
6349dba
Compare
akashsonune
force-pushed
the
fix/side-panel-aria-expanded
branch
from
6349dba to
fdde6f6
Compare
spike-rabbit
requested changes
Apr 14, 2026
Member
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
I think you also need to add an aria-controls (see: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Reference/Attributes/aria-expanded)
Just use a generated ID for that.
akashsonune
force-pushed
the
fix/side-panel-aria-expanded
branch
from
fdde6f6 to
68ac70a
Compare
akashsonune
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation.
Examples.
Dashboards Demo.
Playwright report.
Coverage Reports: