Skip to content

feat(side-panel): improve accessibility #1857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akashsonune wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

feat(side-panel): improve accessibility #1857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions projects/element-ng/side-panel/si-side-panel-content.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@
type="button"
class="side-panel-collapse-toggle btn btn-icon btn-ghost mx-4"
[attr.aria-label]="toggleItemLabel() | translate"
[attr.aria-expanded]="!isCollapsed() || service.isTemporaryOpen()"
[attr.aria-controls]="panelContentId"
(click)="toggleSidePanel($event)"
>
<si-icon
Expand Down
5 changes: 4 additions & 1 deletion projects/element-ng/side-panel/si-side-panel-content.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,13 @@ export interface StatusItem extends MenuItemLegacy {
'[class.collapsed]': 'isCollapsed()',
'[class.expanded]': 'isExpanded()',
'[class.enable-mobile]': 'enableMobile()',
'[class.rpanel-fullscreen-overlay]': 'isFullscreen()'
'[class.rpanel-fullscreen-overlay]': 'isFullscreen()',
'[id]': 'panelContentId'
}
})
export class SiSidePanelContentComponent implements OnInit {
private static idCounter = 0;
protected readonly panelContentId = `__si-side-panel-content-${SiSidePanelContentComponent.idCounter++}`;
/**
* @deprecated This input is no longer used. The collapsible state is managed by the SiSidePanelService.
* This input will be removed in a future major version.
Expand Down
Loading