SPIKE: Protocol 28 (CAP-0084)#2
Closed
sisuresh wants to merge 1 commit into
Closed
Conversation
Pin stellar-xdr to rs-stellar-xdr#548 (bd30d420ce6f63ccd9360e371830384cb84d1c04,
xdr submodule = stellar-xdr#305 head 2769fed744c4ec5a2cf6581addfc1704abfcba7c)
and enable the cap_0083 + cap_0084 features so the JSON codec can decode
muxed-contract addresses (SC_ADDRESS_TYPE_MUXED_CONTRACT = 5 /
MuxedContract { id, contract_id } on the SCAddress union).
This rev uses the per-cap-feature layout (no 'curr' module), so:
- src/lib.rs and tests/tests.rs import XDR types from the crate root.
- type_enum feature added (required for the dynamic Type/TypeVariant the
codec relies on; previously implied by 'curr').
- wasm-opt disabled to match the pre-release dep (mirrors CAP-71 SPIKE).
- list_of_types golden test regenerated (adds MuxedContract +
StellarValueProposedValue + Soroban delegate-signature arms).
Local-only SPIKE. Do not push.
Owner
Author
|
Downstream: consumed by the Lab CAP-0084 SPIKE — sisuresh/laboratory#2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
stellar-xdrto rs-stellar-xdr#548 @bd30d420ce6f63ccd9360e371830384cb84d1c04(carries stellar-xdr#305.x).cap_0083+cap_0084; addtype_enum; dropcurr(per-cap layout has nocurrmodule); import XDR types from crate root insrc/lib.rs/tests/tests.rs.MuxedContract(CAP-0084) + CAP-0083 types intypes()/decode/guess/encode; regeneratelist_of_typesgolden test.wasm-opt = false(local binaryen rejects pre-release bulk-memory ops).Deferred
stellar-xdr = "27.x"+ re-enablewasm-optonce #548 releases (auto-greenscheck-git-rev-deps/cargo-deny/complete); then undraft.26.0.0; bump viabump-version.ymlat release.Expected-red while git-rev pinned:
check-git-rev-deps, aggregatecomplete,cargo-deny (sources).build-and-testis the real signal (green).Upstream
stellar/stellar-xdr#305 -> stellar/rs-stellar-xdr#548 -> this
Downstream
stellar-laboratory (next in chain)