SPIKE: Protocol 28 (CAP-0084)#2
Closed
sisuresh wants to merge 1 commit into
Closed
Conversation
Pin the JS XDR stack to the CAP-0084 SPIKE forks so lab can decode and render
the new SC_ADDRESS_TYPE_MUXED_CONTRACT arm on SCAddress:
- package.json: @stellar/stellar-sdk + @stellar/stellar-xdr-json → local CAP-0084
tarballs (local-pkgs/)
- pnpm-workspace.yaml: override @stellar/stellar-base → CAP-0084 fork tarball so
all transitive consumers (sdk lib/, wallets-kit) share the patched codec
- createStore.ts: NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE} fallbacks
for the Quickstart-bundled lab
Upstream SPIKE PRs (cross-linked):
- js-stellar-base sisuresh/js-stellar-base#2
- js-stellar-sdk sisuresh/js-stellar-sdk#2
- js-stellar-xdr-json sisuresh/js-stellar-xdr-json#2
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft SPIKE — pins lab's JS XDR stack to the CAP-0084 forks so it can decode/render the new
SC_ADDRESS_TYPE_MUXED_CONTRACTarm onSCAddress.Changes
@stellar/stellar-sdk+@stellar/stellar-xdr-jsonto local CAP-0084 tarballs (local-pkgs/);pnpmoverride on@stellar/stellar-base→ CAP-0084 fork so the whole tree shares the patched codec.createStore.ts:NEXT_PUBLIC_CUSTOM_{HORIZON_URL,RPC_URL,PASSPHRASE}fallbacks for the Quickstart-bundled lab.lint:ts,pnpm build,test:unit(92/92).Deferred
file:pins → semver and droplocal-pkgs/+ the base override once the forks publish to npm.@stellar-expert/contract-wasm-interface-parserstays on registrystellar-base@15.0.0(peer dep the override can't reach) — fine, CAP-0084 doesn't change contract-spec XDR.Upstream