Skip to content

ci: fail the notify job when the announcement is rejected - #1701

Merged
zimeg merged 1 commit into
mainfrom
notify-errors-true
Nov 14, 2026
Merged

zimeg merged 1 commit into
mainfrom
notify-errors-true

Conversation

@zimeg

@zimeg zimeg commented Nov 13, 2026

Copy link
Copy Markdown
Member

This pull request sets errors: true on the release announcement step, so a webhook that rejects the post fails the notify job instead of logging an error and staying green.

         uses: slackapi/slack-github-action@dcb1066f776dd043e64d0e8ba94ca15cc7e1875d # v4.0.0
         with:
+          errors: true
           webhook: ${{ secrets.SLACK_RELEASE_ANNOUNCEMENTS_WEBHOOK_URL }}

Testing

  • On the next release, confirm the announcement posts and the notify job stays green.

Category (place an x in each of the [ ])

  • bolt (Bolt for Java)
  • bolt-{sub modules} (Bolt for Java - optional modules)
  • slack-api-client (Slack API Clients)
  • slack-api-model (Slack API Data Models)
  • slack-api-*-kotlin-extension (Kotlin Extensions for Slack API Clients)
  • slack-app-backend (The primitive layer of Bolt for Java)

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you agree to those rules.

🤖 Generated with Claude Code

Co-Authored-By: Claude <svc-devxp-claude@slack-corp.com>
@zimeg
zimeg requested a review from a team as a code owner November 13, 2026 23:58
@zimeg zimeg added this to the 1.55.1 milestone Nov 13, 2026
@zimeg zimeg added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2026
@zimeg zimeg self-assigned this Nov 13, 2026
@codecov

codecov Bot commented Nov 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.03%. Comparing base (6873c87) to head (6be2f3f).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1701      +/-   ##
============================================
+ Coverage     73.99%   74.03%   +0.04%     
- Complexity     4755     4758       +3     
============================================
  Files           487      487              
  Lines         14811    14811              
  Branches       1536     1536              
============================================
+ Hits          10960    10966       +6     
+ Misses         2937     2934       -3     
+ Partials        914      911       -3     
Flag Coverage Δ
jdk-14 74.03% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@mwbrooks mwbrooks left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thanks @zimeg! With this, a revoked webhook can't hide behind a green notify job anymore.

@zimeg

zimeg commented Nov 14, 2026

Copy link
Copy Markdown
Member Author

☕ Thanks for the kind review @mwbrooks! A revoked webhook can't hide behind a green job here anymore 🔔

@zimeg
zimeg merged commit 66ca90f into main Nov 14, 2026
7 checks passed
@zimeg
zimeg deleted the notify-errors-true branch November 14, 2026 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants