test(e2e): repair test-api-e2e.sh for removed legacy 'call tool'#534
Merged
Conversation
The env/args/headers block (Issue #182 tests) drove the deleted `mcpproxy call tool upstream_servers` command; its intent-based replacements reject built-in tools and the dedicated `upstream` subcommands have different semantics (merge vs full-replace, no args update). That coverage already lives in Go (TestEnvJsonParsing / TestArgsJsonParsing / TestHeadersJsonParsing / TestPatchPreservesEnvAndHeaders / TestHandleRemoveUpstream), so the 13 redundant bash tests are removed. Also fixes two unrelated breakages surfaced while verifying: - the echo_tool history-seed call now uses `call tool-read` - the activity/{id} detail check used `.data.id`; the contract nests the record under `.data.activity.id` Script is green again: 65 passed, 0 failed.
Deploying mcpproxy-docs with
|
| Latest commit: |
1d3c8c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cb7bf058.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-e2e-script-stale-call-to.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26577484140 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./scripts/test-api-e2e.sh(the "required" local E2E gate) was failing 10/78 because it still drove the removed legacymcpproxy call tool upstream_servers ...command. The replacement intent variants (call tool-read/write/destructive) reject built-in tools (requireserver:tool), and the dedicatedupstreamsubcommands have different semantics (merge vs full-replace, no args-update, no json-string validation) — so the env/args/headers tests (Issue #182) can't be faithfully ported to the CLI.That behavior is already covered by Go tests, so the redundant bash tests are removed:
TestEnvJsonParsing,TestArgsJsonParsing,TestHeadersJsonParsingTestPatchPreservesEnvAndHeaders,TestHandleRemoveUpstream,TestUpstreamServerOperationsChanges
echo_toolhistory-seed now usescall tool-read -d.activity/{id}detail check: contract nests the record under.data.activity.id, not.data.id.Result
1 insertion, 154 deletions. Script is green: 65 passed, 0 failed.(The external Pulse-registry test is intermittently flaky — unrelated, not touched here.)