fix(ci): point Server Edition test job at internal/serveredition (not deleted internal/teams)#680
Merged
Merged
Conversation
… deleted internal/teams) The Server Edition CI job (added #631) ran: go test -race -tags server ./internal/teams/... ./internal/config/... But the Teams->Server Edition rename (#603) moved that code to internal/serveredition/, and #679 deleted the last stale internal/teams/ file. So the job failed with 'lstat ./internal/teams/: no such file or directory' — and before that, it was silently testing the wrong (stale, near-empty) path, never the real serveredition packages. Fix: test ./internal/serveredition/... instead. Verified locally: go test -race -tags server ./internal/serveredition/... ./internal/config/... -> all 8 packages ok. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
![mcpproxy-gatekeeper[bot]](https://avatars.githubusercontent.com/u/216428285?s=60&v=4){kind=small}
Deploying mcpproxy-docs with
|
| Latest commit: |
195d46b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://26c22456.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-server-edition-ci-server.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Server EditionCI job (added in #631) runs:But the Teams→Server Edition rename (#603) moved that code to
internal/serveredition/, and #679 removed the last staleinternal/teams/file. The job now fails:Worse: before #679 it was silently testing the stale, near-empty
internal/teams/path — never the realinternal/serveredition/packages (the multi-user/auth/broker/workspace code). So the job gave false confidence.Fix
Test
./internal/serveredition/...instead. One-line workflow change.Verification (local, exact CI command)
go test -race -tags server ./internal/serveredition/... ./internal/config/...→ all 8 packagesok(serveredition + api + auth + broker + multiuser + users + workspace + config).Follow-up to #679 (MCP-2455). Unblocks the Server Edition check on all open PRs once they pick up this workflow.
🤖 Generated with Claude Code