[DNM] Go SDK examples #1146
Draft
[DNM] Go SDK examples #1146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolag
force-pushed
the
rtinianov_sdk_with_examples
branch
from
b1f4032 to
967e015
Compare
nolag
force-pushed
the
rtinianov_sdk_with_examples
branch
2 times, most recently
from
9bec3f2 to
9288d44
Compare
jmank88
reviewed
Apr 23, 2025
Makefile
Outdated
| @@ -1,6 +1,6 @@ | |||
| .PHONY: gomods | |||
| gomods: ## Install gomods | |||
| go install github.com/jmank88/[email protected].5 | |||
| go install github.com/jmank88/[email protected].3 | |||
There was a problem hiding this comment.
Oh the whole file actually
jmank88
reviewed
Apr 23, 2025
pkg/workflows/sdk/v2/promise.go
Outdated
Comment on lines
7
to
14
| type Promise[T any] interface { | ||
| Await() (T, error) | ||
| CapabilityPromise | ||
| } | ||
|
|
||
| type CapabilityPromise interface { | ||
| promise() | ||
| } |
There was a problem hiding this comment.
Why is it important to prevent user created Promises?
If it is not strictly necessary, then this sort of flexibility would be nice:
Suggested change
| type Promise[T any] interface { | |
| Await() (T, error) | |
| CapabilityPromise | |
| } | |
| type CapabilityPromise interface { | |
| promise() | |
| } | |
| type Promise[T any] func() (T, error) |
There was a problem hiding this comment.
Why is it important to prevent user created Promises?
Oh but they could just call the constructors below anyways?
jmank88
reviewed
Apr 23, 2025
pkg/workflows/sdk/v2/promise.go
Outdated
| return &basicPromise[T]{resolved: result, err: err, isResolved: true} | ||
| } | ||
|
|
||
| type basicPromise[T any] struct { |
There was a problem hiding this comment.
Does this behave differently than sync.OnceValues? It seems like we could leverage that, or even just expect callers to use it directly instead.
nolag
force-pushed
the
rtinianov_sdk_with_examples
branch
from
a518da6 to
da384fb
Compare
nolag
force-pushed
the
rtinianov_sdk_with_examples
branch
from
f50b735 to
4485ad2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To see the test only, diff against rtinianov_feature_sdk_vf.