-
Notifications
You must be signed in to change notification settings - Fork 3
feat: attempt to add a fediwall listening to Snakemake hashtags #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds CI steps to setup Node.js 18 and download, verify, extract, and install a Fediwall release and generate a static wall-config.json before the existing build step. Also adds a "Community Wall" link to site header navigation. Changes
Sequence Diagram(s)sequenceDiagram
participant GH as GitHub Actions Runner
participant Repo as Repository
participant Node as actions/setup-node@v4
participant FW as Fediwall provisioning script
participant Build as Existing build step
participant Deploy as Deploy step
GH->>Repo: actions/checkout
GH->>Node: setup Node.js (18)
Note right of Node: new CI step
GH->>FW: download specific Fediwall release
FW->>FW: verify SHA256 checksum
FW->>FW: extract & copy to build/fediwall
FW->>FW: write wall-config.json
FW->>FW: cleanup temp files
Note right of FW: new provisioning sequence
GH->>Build: run existing build (e.g., locosopa)
GH->>Deploy: deploy artifacts
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/build_and_deploy.yml
(1 hunks)src/config.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (1)
.github/workflows/build_and_deploy.yml (1)
41-58
: Unable to verify Fediwall archive structure automaticallyThe automated download of fediwall.zip isn’t returning a valid ZIP, so we can’t confirm whether
index.html
ends up atbuild/fediwall/index.html
. Please manually download and inspect the latest release archive to ensureindex.html
is at the root of the extracted folder—update thecp -r
invocation if it’s nested under an extra directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/build_and_deploy.yml (1)
55-55
: Include dotfiles when copying the extracted bundle.
cp -r fediwall-temp/* …
skips leading-dot entries (e.g..nojekyll
), which many single-page app bundles rely on for GitHub Pages to serve correctly. Please switch to a form that preserves dotfiles and metadata, e.g.cp -a fediwall-temp/. build/fediwall/
.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/build_and_deploy.yml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
the test yields
no idea, what might cause this due to the changed yaml. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I think it would be cool to have this as part of locosopa (the action for the homepage building) itself. This would also simplify the testing, since it does not take so long for the test data there as it needs with all the snakemake contributors to be queried here. You can add it as a rule to this workflow: https://github.com/koesterlab/locosopa/blob/main/locosopa/workflow/Snakefile
E.g. with a little python script, which would maybe also be more readable than this bash script. Let me know whether that would work for you. Otherwise, I could also do that or at least help with that.
Actually, I was not aware of locosopa until I attempted this PR ;-). I can give it a go. |
Hi,
This is an attempt to produce a fediwall extension to the Snakemake homepage. If it works, and I have NO idea, it will be under https://snakemake.readthedocs.io/fediwall and - in a 2nd stage - may replace the personalized Mastodon link.
It currently should listen to the following hashtags (hashtags are not case sensitive, they do not allow a regex either):
Summary by CodeRabbit
New Features
Chores