fix(iOS, Tabs): overrideScrollViewContentInsetAdjustmentBehavior in managed tabs
#3441
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
overrideScrollViewContentInsetAdjustmentBehaviorin managed tabs on iOS, Fabric.before3441.mov
after3441.mov
Paper
On Paper, due to the order of mounting children, we are unable to consistently find and override scroll view behavior in time (when the entire hierarchy is mounted under screen but before screen is shown). The best solution I found (
dispatch_asyncindidUpdateReactSubviews) worked 50% of the time.For now, we decided not to implement support for the prop on Paper.
Ticket to research Paper support: https://github.com/software-mansion/react-native-screens-labs/issues/283.
Changes
mountChildComponentViewTest code and steps to reproduce
Run
TestBottomTabs. Change Tab4 to use transparent header on first screen. Open Tab3, Tab4. ScrollViews should respect safe area insets.Use controlled and managed bottom tabs, with and without freeze.
Checklist