Skip to content

fix(iOS, Tabs): overrideScrollViewContentInsetAdjustmentBehavior in managed tabs #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kligarski wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(iOS, Tabs): overrideScrollViewContentInsetAdjustmentBehavior in managed tabs #3441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd9eb19
move finding scrollview to mountChildComponentView
kligarski Dec 1, 2025
4247a9c
update docs
kligarski Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ios/bottom-tabs/host/RNSTabBarController.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,7 @@ - (void)updateSelectedViewController
} else {
self.tabBar.overrideUserInterfaceStyle = selectedViewController.tabScreenComponentView.userInterfaceStyle;
}
[selectedViewController.tabScreenComponentView overrideScrollViewBehaviorInFirstDescendantChainIfNeeded];
[selectedViewController.tabScreenComponentView updateContentScrollViewEdgeEffectsIfExists];

[self setSelectedViewController:selectedViewController];
}

Expand Down
2 changes: 2 additions & 0 deletions ios/bottom-tabs/screen/RNSBottomTabsScreenComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,6 +456,8 @@ - (void)mountChildComponentView:(UIView<RCTComponentViewProtocol> *)childCompone
{
RNSLog(@"TabScreen [%ld] mount [%ld] at %ld", self.tag, childComponentView.tag, index);
[super mountChildComponentView:childComponentView index:index];
[self overrideScrollViewBehaviorInFirstDescendantChainIfNeeded];
[self updateContentScrollViewEdgeEffectsIfExists];
}

- (void)unmountChildComponentView:(UIView<RCTComponentViewProtocol> *)childComponentView index:(NSInteger)index
Expand Down
3 changes: 0 additions & 3 deletions src/components/bottom-tabs/BottomTabs.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,9 +261,6 @@ export interface BottomTabsProps extends ViewProps {
* If set to false, tab screen change will not be prevented by the
* native side (managed/natively-driven).
*
* On iOS, some features are not fully implemented for managed tabs
* (e.g. overrideScrollViewContentInsetAdjustmentBehavior).
*
* On Android, only controlled tabs are currently supported and the
* value of this prop is ignored.
*
Expand Down
2 changes: 2 additions & 0 deletions src/components/bottom-tabs/BottomTabsScreen.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,6 +496,8 @@ export interface BottomTabsScreenProps {
* prevents ScrollViews from respecting navigation bar insets.
* When this prop is set to `true`, `automatic` behavior is reverted.
*
* Supported only on Fabric.
*
* @default true
*
* @platform ios
Expand Down
Loading