Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the get_aca_images default to bgsub=False #188

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

jeanconn
Copy link
Contributor

Description

Change the get_aca_images default to bgsub=False

Interface impacts

Testing

Tested in a recent 2025.0 test env.

Unit tests

  • Mac
(2025.0) flame:chandra_aca jean$ git rev-parse HEAD
5181dde2a01fceeb1396402b124576fcf7245c13
(2025.0) flame:chandra_aca jean$ pytest
========================================================== test session starts ==========================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/jean/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 230 items                                                                                                                     

chandra_aca/tests/test_aca_image.py ..................                                                                            [  7%]
chandra_aca/tests/test_all.py ........................                                                                            [ 18%]
chandra_aca/tests/test_attitude.py .............................................................                                  [ 44%]
chandra_aca/tests/test_dark_model.py ............                                                                                 [ 50%]
chandra_aca/tests/test_dark_subtract.py ........                                                                                  [ 53%]
chandra_aca/tests/test_drift.py ..........................                                                                        [ 64%]
chandra_aca/tests/test_maude_decom.py .........................                                                                   [ 75%]
chandra_aca/tests/test_planets.py ...............                                                                                 [ 82%]
chandra_aca/tests/test_psf.py ...                                                                                                 [ 83%]
chandra_aca/tests/test_residuals.py ss...                                                                                         [ 85%]
chandra_aca/tests/test_star_probs.py .................................                                                            [100%]

=========================================================== warnings summary

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@jeanconn jeanconn changed the base branch from master to ruff-update January 10, 2025 14:55
Copy link
Member

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Base automatically changed from ruff-update to master January 10, 2025 16:55
@jeanconn jeanconn merged commit 7bcfac4 into master Jan 10, 2025
2 checks passed
@jeanconn jeanconn deleted the images-default branch January 10, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants