Skip to content

Change the get_aca_images default to bgsub=False #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Change the get_aca_images default to bgsub=False #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chandra_aca/aca_image.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ def get_psf_image(

@retry.retry(exceptions=requests.exceptions.RequestException, delay=5, tries=3)
def get_aca_images(
start: CxoTimeLike, stop: CxoTimeLike, bgsub=True, source="maude", **maude_kwargs
start: CxoTimeLike, stop: CxoTimeLike, bgsub=False, source="maude", **maude_kwargs
) -> Table:
"""
Get ACA images and ancillary data from either the MAUDE or CXC data sources.
Expand Down Expand Up @@ -880,7 +880,7 @@ def get_aca_images(
stop : CxoTimeLike
Stop time (CXC sec).
bgsub : bool
Include background subtracted images in output table.
Include background subtracted images in output table. Default is False.
source : str
Data source for image and temperature telemetry ('maude' or 'cxc'). For 'cxc',
the image telemetry is from mica and temperature telemetry is from CXC L0 via
Expand Down
2 changes: 1 addition & 1 deletion chandra_aca/tests/test_dark_subtract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ def test_dcsub_aca_images_maude():
imgs_table, img_dark=img_dark, tccd_dark=tccd_dark, t_ccd_vals=t_ccds
)

imgs_bgsub_table = get_aca_images(tstart, tstop, source="maude")
imgs_bgsub_table = get_aca_images(tstart, tstop, source="maude", bgsub=True)

exp0 = np.array(
[
Expand Down
Loading