-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify intent selector, model selector, and agentic chat dropdown #6690
base: main
Are you sure you want to change the base?
Conversation
527e09f
to
2d34d03
Compare
2757dbe
to
2e656dc
Compare
461c851
to
7937fee
Compare
.gitignore
Outdated
.aiderignore | ||
.aider.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested the build locally but left some questions inline about the missing feature flags check for agentic chat (deep cody) - do we need to add them back?
map(([enableToolCody, models]) => { | ||
const handlers: OmniboxHandlerOption[] = [] | ||
handlers.push(OmniboxHandlers.Auto) | ||
handlers.push(OmniboxHandlers.DeepCody) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need to check if they have the feature flags for agentic chat and terminal access before we add the handler?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, agentic chat is now enabled by default and terminal access I think we should just turn on, given that it always asks for permission anyway.
4197dfd
to
631a3d7
Compare
omni-selector.mov
TODO
Later
Test plan
Test locally