Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify intent selector, model selector, and agentic chat dropdown #6690

Draft
wants to merge 49 commits into
base: main
Choose a base branch
from

Conversation

beyang
Copy link
Member

@beyang beyang commented Jan 18, 2025

omni-selector.mov

TODO

  • Icons
  • setAgent (setHandler) should also set model
  • Remove intent status update except when using 'auto' handler
  • Update intent button
  • Update ToolboxManager
  • Remove hardcoded "deep-cody" (all instances)
  • Default agentID needs to be consistent with what's selected in UI (right now defaults to "deep-cody")
  • When code search intent is detected with "agentic chat" selected, response is empty
  • fix getTooltip
  • "Agent" -> "Handler" renames
  • Create chat/setAgent handler
  • Fix tests

Later

  • Port ToolCody over

Test plan

Test locally

@beyang beyang force-pushed the bl/unify-intent-model-selector branch from 527e09f to 2d34d03 Compare January 18, 2025 01:26
@beyang beyang force-pushed the bl/unify-intent-model-selector branch from 2757dbe to 2e656dc Compare January 18, 2025 08:32
@beyang beyang force-pushed the bl/unify-intent-model-selector branch from 461c851 to 7937fee Compare January 18, 2025 21:50
@beyang beyang changed the title draft Unify intent selector, model selector, and agentic chat dropdown Jan 19, 2025
@beyang beyang marked this pull request as ready for review January 19, 2025 09:50
@beyang beyang requested a review from abeatrix January 19, 2025 09:50
.gitignore Outdated
Comment on lines 50 to 51
.aiderignore
.aider.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested the build locally but left some questions inline about the missing feature flags check for agentic chat (deep cody) - do we need to add them back?

map(([enableToolCody, models]) => {
const handlers: OmniboxHandlerOption[] = []
handlers.push(OmniboxHandlers.Auto)
handlers.push(OmniboxHandlers.DeepCody)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need to check if they have the feature flags for agentic chat and terminal access before we add the handler?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, agentic chat is now enabled by default and terminal access I think we should just turn on, given that it always asks for permission anyway.

@beyang beyang marked this pull request as draft February 12, 2025 05:10
@beyang beyang force-pushed the bl/unify-intent-model-selector branch from 4197dfd to 631a3d7 Compare February 17, 2025 18:56
@beyang beyang requested a review from abeatrix February 18, 2025 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants