loading indicator for search

sourcegraph · beyang · Jan 17, 2025 · Dec 31, 2024 · Dec 31, 2024 · Jan 18, 2025
commit 348d3e097d734c387482e327a897ac5fd2437c84
diff --git a/lib/shared/src/models/sync.ts b/lib/shared/src/models/sync.ts
@@ -26,7 +26,7 @@ import { RestClient } from '../sourcegraph-api/rest/client'
 import type { UserProductSubscription } from '../sourcegraph-api/userProductSubscription'
 import { CHAT_INPUT_TOKEN_BUDGET } from '../token/constants'
 import { isError } from '../utils'
-import { TOOL_CODY_MODEL, ToolCodyModelName, getExperimentalClientModelByFeatureFlag } from './client'
+import { TOOL_CODY_MODEL, ToolCodyModelName } from './client'
 import { type Model, type ServerModel, createModel, createModelFromServerModel } from './model'
 import type {
     DefaultsAndUserPreferencesForEndpoint,
@@ -235,31 +235,9 @@ export function syncModels({
 
                                                 const clientModels = []
 
-                                                // Handle agentic chat features
-                                                const isAgenticChatEnabled =
-                                                    hasAgenticChatFlag ||
-                                                    (isDotComUser && !isCodyFreeUser)
                                                 const haikuModel = data.primaryModels.find(m =>
                                                     m.id.includes('5-haiku')
                                                 )
-                                                const sonnetModel = data.primaryModels.find(m =>
-                                                    m.id.includes('5-sonnet')
-                                                )
-                                                const hasDeepCody = data.primaryModels.some(m =>
-                                                    m.id.includes('deep-cody')
-                                                )
-                                                if (
-                                                    !hasDeepCody &&
-                                                    isAgenticChatEnabled &&
-                                                    sonnetModel &&
-                                                    haikuModel
-                                                ) {
-                                                    clientModels.push(
-                                                        getExperimentalClientModelByFeatureFlag(
-                                                            FeatureFlag.DeepCody
-                                                        )!
-                                                    )
-                                                }
 
                                                 const hasToolCody = data.primaryModels.some(m =>
                                                     m.id.includes(ToolCodyModelName)

diff --git a/vscode/webviews/chat/Transcript.tsx b/vscode/webviews/chat/Transcript.tsx
@@ -546,13 +546,24 @@ const TranscriptInteraction: FC<TranscriptInteractionProps> = memo(props => {
                     switchToSearch={() => editAndSubmitSearch(assistantMessage?.didYouMeanQuery ?? '')}
                 />
             )}
-            {!usingToolCody && !isSearchIntent && humanMessage.agent && (
+            {humanMessage.agent === DeepCodyAgentID ? (
                 <AgenticContextCell
                     key={`${humanMessage.index}-${humanMessage.intent}-process`}
                     isContextLoading={isContextLoading}
                     processes={humanMessage?.processes ?? undefined}
                 />
+            ) : (
+                <>
+                    {isContextLoading && (
+                        <div className="flex justify-center items-center h-full">
+                            <div className="tw-mt-6">
+                                <i className="codicon codicon-loading codicon-modifier tw-animate-spin" />
+                            </div>
+                        </div>
+                    )}
+                </>
             )}
+
             {!isSearchIntent &&
                 humanMessage.agent &&
                 isContextLoading &&

diff --git a/vscode/src/jsonrpc/agent-protocol.ts b/vscode/src/jsonrpc/agent-protocol.ts
 } from '@sourcegraph/cody-shared'
 import type { TelemetryEventMarketingTrackingInput } from '@sourcegraph/telemetry'

 import { HandlerID } from '@sourcegraph/cody-shared/src/models/model'
 import type { ExtensionMessage, WebviewMessage } from '../chat/protocol'
 import type { CompletionBookkeepingEvent, CompletionItemID } from '../completions/analytics-logger'
 import type { FixupTaskID } from '../non-stop/FixupTask'
diff --git a/lib/shared/src/models/sync.test.ts b/lib/shared/src/models/sync.test.ts
        vi.spyOn(modelsService, 'modelsChanges', 'get').mockReturnValue(Observable.of(result))

        // Check if Deep Cody model is in the primary models list.
        expect(result.primaryModels.some(model => model.id.includes('deep-cody'))).toBe(true)

        // Deep Cody should not replace the default chat / edit model.
        expect(result.preferences.defaults.chat?.includes('deep-cody')).toBe(false)
diff --git a/vscode/src/services/LocalStorageProvider.ts b/vscode/src/services/LocalStorageProvider.ts

    private get storage(): Memento {
        if (!this._storage) {
            throw new Error('LocalStorage not initialized')
        }

        return this._storage
diff --git a/vscode/webviews/chat/Transcript.test.tsx b/vscode/webviews/chat/Transcript.test.tsx

        // Check if the model selector is rendered
        const modelSelector = container.querySelector('[data-testid="chat-model-selector"]')
        expect(modelSelector).not.toBeNull()
        expect(modelSelector?.textContent).toEqual(FIXTURE_MODELS[0].title)

        // Open the menu on click
diff --git a/vscode/webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx b/vscode/webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx
        test('model selector is showing up with the default model name', () => {
            const { container } = renderWithMocks({})
            const modelSelector = container.querySelector('[data-testid="chat-model-selector"]')
            expect(modelSelector).not.toBeNull()
            expect(modelSelector?.textContent).toEqual(FIXTURE_MODELS[0].title)
        })
    })
diff --git a/vscode/test/e2e/chat-input.test.ts b/vscode/test/e2e/chat-input.test.ts
    const modelSelect = chatFrame.getByRole('combobox', { name: 'Select a model' }).last()

    await expect(modelSelect).toBeEnabled()
    await expect(modelSelect).toHaveText(/^Claude 3.5 Sonnet/)

    await firstChatInput.fill('to model1')
    await firstChatInput.press('Enter')
diff --git a/vscode/src/chat/chat-view/prompt.test.ts b/vscode/src/chat/chat-view/prompt.test.ts
            const actual = prompt[i].text?.toString()
            const expected = expectedPrefixes[i]
            if (!actual?.includes(expected)) {
                expect.fail(
                    `Message mismatch: expected ${JSON.stringify(actual)} to include ${JSON.stringify(
                        expectedPrefixes[i]
                    )}`
diff --git a/vscode/test/e2e/enterprise-server-sent-models.test.ts b/vscode/test/e2e/enterprise-server-sent-models.test.ts

    // First model in the server list should be selected as default
    await expect(modelSelect).toBeEnabled()
    await expect(modelSelect).toHaveText(/^Opus/)

    // Change selection to Titan and assert it was updated
    // Note: currently the backend doesn't respect frontend enterprise
	} from '@sourcegraph/cody-shared'
	import type { TelemetryEventMarketingTrackingInput } from '@sourcegraph/telemetry'

	import { HandlerID } from '@sourcegraph/cody-shared/src/models/model'
Check failure on line 17 in vscode/src/jsonrpc/agent-protocol.ts GitHub Actions / build `All these imports are only used as types.`
	import type { ExtensionMessage, WebviewMessage } from '../chat/protocol'
	import type { CompletionBookkeepingEvent, CompletionItemID } from '../completions/analytics-logger'
	import type { FixupTaskID } from '../non-stop/FixupTask'
	vi.spyOn(modelsService, 'modelsChanges', 'get').mockReturnValue(Observable.of(result))

	// Check if Deep Cody model is in the primary models list.
	expect(result.primaryModels.some(model => model.id.includes('deep-cody'))).toBe(true)
Check failure on line 537 in lib/shared/src/models/sync.test.ts GitHub Actions / test-unit (ubuntu, 20) src/models/sync.test.ts > syncModels > not to set Agentic Chat as default chat model when feature flag is enabled `AssertionError: expected false to be true // Object.is equality - Expected + Received - true + false ❯ src/models/sync.test.ts:537:84` Check failure on line 537 in lib/shared/src/models/sync.test.ts GitHub Actions / test-unit (windows, 20) src/models/sync.test.ts > syncModels > not to set Agentic Chat as default chat model when feature flag is enabled `AssertionError: expected false to be true // Object.is equality - Expected + Received - true + false ❯ src/models/sync.test.ts:537:84` Check failure on line 537 in lib/shared/src/models/sync.test.ts GitHub Actions / test-unit (ubuntu, 18) src/models/sync.test.ts > syncModels > not to set Agentic Chat as default chat model when feature flag is enabled `AssertionError: expected false to be true // Object.is equality - Expected + Received - true + false ❯ src/models/sync.test.ts:537:84`

	// Deep Cody should not replace the default chat / edit model.
	expect(result.preferences.defaults.chat?.includes('deep-cody')).toBe(false)

	private get storage(): Memento {
	if (!this._storage) {
	throw new Error('LocalStorage not initialized')
Check failure on line 57 in vscode/src/services/LocalStorageProvider.ts GitHub Actions / test-unit (ubuntu, 20) src/chat/agentic/CodyTool.test.ts > CodyTool > should register and retrieve tools correctly Error: LocalStorage not initialized ❯ LocalStorage.get storage [as storage] src/services/LocalStorageProvider.ts:57:19 ❯ LocalStorage.get src/services/LocalStorageProvider.ts:365:21 ❯ LocalStorage.getChatMemory src/services/LocalStorageProvider.ts:337:21 ❯ CodyChatMemory.getChatMemory src/chat/agentic/CodyChatMemory.ts:68:38 ❯ Function.initialize src/chat/agentic/CodyChatMemory.ts:31:54 ❯ new MemoryTool src/chat/agentic/CodyTool.ts:370:24 ❯ Object.ToolFactory.register.createInstance src/chat/agentic/CodyToolProvider.ts:67:29 ❯ src/chat/agentic/CodyToolProvider.ts:88:42 ❯ TestToolFactory.getInstances src/chat/agentic/CodyToolProvider.ts:88:14 Check failure on line 57 in vscode/src/services/LocalStorageProvider.ts GitHub Actions / test-unit (windows, 20) src/chat/agentic/CodyTool.test.ts > CodyTool > should register and retrieve tools correctly Error: LocalStorage not initialized ❯ LocalStorage.get storage [as storage] src/services/LocalStorageProvider.ts:57:19 ❯ LocalStorage.get src/services/LocalStorageProvider.ts:365:21 ❯ LocalStorage.getChatMemory src/services/LocalStorageProvider.ts:337:21 ❯ CodyChatMemory.getChatMemory src/chat/agentic/CodyChatMemory.ts:68:38 ❯ Function.initialize src/chat/agentic/CodyChatMemory.ts:31:54 ❯ new MemoryTool src/chat/agentic/CodyTool.ts:370:24 ❯ Object.ToolFactory.register.createInstance src/chat/agentic/CodyToolProvider.ts:67:29 ❯ src/chat/agentic/CodyToolProvider.ts:88:42 ❯ TestToolFactory.getInstances src/chat/agentic/CodyToolProvider.ts:88:14 Check failure on line 57 in vscode/src/services/LocalStorageProvider.ts GitHub Actions / test-unit (ubuntu, 18) src/chat/agentic/CodyTool.test.ts > CodyTool > should register and retrieve tools correctly Error: LocalStorage not initialized ❯ LocalStorage.get storage [as storage] src/services/LocalStorageProvider.ts:57:19 ❯ LocalStorage.get src/services/LocalStorageProvider.ts:365:21 ❯ LocalStorage.getChatMemory src/services/LocalStorageProvider.ts:337:21 ❯ CodyChatMemory.getChatMemory src/chat/agentic/CodyChatMemory.ts:68:38 ❯ Function.initialize src/chat/agentic/CodyChatMemory.ts:31:54 ❯ new MemoryTool src/chat/agentic/CodyTool.ts:370:24 ❯ Object.ToolFactory.register.createInstance src/chat/agentic/CodyToolProvider.ts:67:29 ❯ src/chat/agentic/CodyToolProvider.ts:88:42 ❯ TestToolFactory.getInstances src/chat/agentic/CodyToolProvider.ts:88:14
	}

	return this._storage

	// Check if the model selector is rendered
	const modelSelector = container.querySelector('[data-testid="chat-model-selector"]')
	expect(modelSelector).not.toBeNull()
Check failure on line 51 in vscode/webviews/chat/Transcript.test.tsx GitHub Actions / test-unit (ubuntu, 20) webviews/chat/Transcript.test.tsx > Transcript > renders with provided models `AssertionError: expected null not to be null ❯ webviews/chat/Transcript.test.tsx:51:35` Check failure on line 51 in vscode/webviews/chat/Transcript.test.tsx GitHub Actions / test-unit (windows, 20) webviews/chat/Transcript.test.tsx > Transcript > renders with provided models `AssertionError: expected null not to be null ❯ webviews/chat/Transcript.test.tsx:51:35` Check failure on line 51 in vscode/webviews/chat/Transcript.test.tsx GitHub Actions / test-unit (ubuntu, 18) webviews/chat/Transcript.test.tsx > Transcript > renders with provided models `AssertionError: expected null not to be null ❯ webviews/chat/Transcript.test.tsx:51:35`
	expect(modelSelector?.textContent).toEqual(FIXTURE_MODELS[0].title)

	// Open the menu on click
	test('model selector is showing up with the default model name', () => {
	const { container } = renderWithMocks({})
	const modelSelector = container.querySelector('[data-testid="chat-model-selector"]')
	expect(modelSelector).not.toBeNull()
Check failure on line 139 in vscode/webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx GitHub Actions / test-unit (ubuntu, 20) webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx > HumanMessageEditor > submitting > model selector is showing up with the default model name `AssertionError: expected null not to be null ❯ webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx:139:39` Check failure on line 139 in vscode/webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx GitHub Actions / test-unit (windows, 20) webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx > HumanMessageEditor > submitting > model selector is showing up with the default model name `AssertionError: expected null not to be null ❯ webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx:139:39` Check failure on line 139 in vscode/webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx GitHub Actions / test-unit (ubuntu, 18) webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx > HumanMessageEditor > submitting > model selector is showing up with the default model name `AssertionError: expected null not to be null ❯ webviews/chat/cells/messageCell/human/editor/HumanMessageEditor.test.tsx:139:39`
	expect(modelSelector?.textContent).toEqual(FIXTURE_MODELS[0].title)
	})
	})
	const modelSelect = chatFrame.getByRole('combobox', { name: 'Select a model' }).last()

	await expect(modelSelect).toBeEnabled()
	await expect(modelSelect).toHaveText(/^Claude 3.5 Sonnet/)
Check failure on line 208 in vscode/test/e2e/chat-input.test.ts GitHub Actions / test-e2e (ubuntu, 2/5) chat-input.test.ts:197:3 › chat model selector 1) chat-input.test.ts:197:3 › chat model selector ──────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: frameLocator('iframe.webview:first-child:last-child').frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() Expected pattern: /^Claude 3.5 Sonnet/ Received string: "Agentic chatExperimental" Call log: - expect.toHaveText with timeout 5000ms - waiting for frameLocator('iframe.webview:first-child:last-child').frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-te Check failure on line 208 in vscode/test/e2e/chat-input.test.ts GitHub Actions / test-e2e (ubuntu, 2/5) chat-input.test.ts:197:3 › chat model selector 1) chat-input.test.ts:197:3 › chat model selector ──────────────────────────────────────────────── Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: frameLocator('iframe.webview:first-child:last-child').frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() Expected pattern: /^Claude 3.5 Sonnet/ Received string: "Agentic chatExperimental" Call log: - expect.toHaveText with timeout 5000ms - waiting for frameLocator('iframe.webview:first-child:last-child').frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:rj:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-

	await firstChatInput.fill('to model1')
	await firstChatInput.press('Enter')
	const actual = prompt[i].text?.toString()
	const expected = expectedPrefixes[i]
	if (!actual?.includes(expected)) {
	expect.fail(
Check failure on line 280 in vscode/src/chat/chat-view/prompt.test.ts GitHub Actions / test-unit (windows, 20) src/chat/chat-view/prompt.test.ts > DefaultPrompter > prefers latest context AssertionError: Message mismatch: expected "Codebase context from file \\enhanced1.ts:\n```typescript:\\enhanced1.ts\nimport vscode```" to include "Codebase context from file enhanced1.ts" ❯ checkPrompt src/chat/chat-view/prompt.test.ts:280:24 ❯ src/chat/chat-view/prompt.test.ts:225:9
	`Message mismatch: expected ${JSON.stringify(actual)} to include ${JSON.stringify(
	expectedPrefixes[i]
	)}`

	// First model in the server list should be selected as default
	await expect(modelSelect).toBeEnabled()
	await expect(modelSelect).toHaveText(/^Opus/)
Check failure on line 19 in vscode/test/e2e/enterprise-server-sent-models.test.ts GitHub Actions / test-e2e (ubuntu, 5/5) enterprise-server-sent-models.test.ts:6:5 › allows multiple enterprise models when server-sent models is enabled 1) enterprise-server-sent-models.test.ts:6:5 › allows multiple enterprise models when server-sent models is enabled Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: frameLocator('.simple-find-part-wrapper + iframe.webview').last().frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() Expected pattern: /^Opus/ Received string: "Agentic chatExperimental" Call log: - expect.toHaveText with timeout 5000ms - waiting for frameLocator('.simple-find-part-wrapper + iframe.webview').last().frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-l Check failure on line 19 in vscode/test/e2e/enterprise-server-sent-models.test.ts GitHub Actions / test-e2e (ubuntu, 5/5) enterprise-server-sent-models.test.ts:6:5 › allows multiple enterprise models when server-sent models is enabled 1) enterprise-server-sent-models.test.ts:6:5 › allows multiple enterprise models when server-sent models is enabled Retry #1 ─────────────────────────────────────────────────────────────────────────────────────── Error: Timed out 5000ms waiting for expect(locator).toHaveText(expected) Locator: frameLocator('.simple-find-part-wrapper + iframe.webview').last().frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() Expected pattern: /^Opus/ Received string: "Agentic chatExperimental" Call log: - expect.toHaveText with timeout 5000ms - waiting for frameLocator('.simple-find-part-wrapper + iframe.webview').last().frameLocator('iframe').getByRole('combobox', { name: 'Select a model' }).last() - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combobox" data-state="closed" aria-expanded="false" aria-haspopup="dialog" aria-controls="radix-:r7:" aria-label="Select a model" data-testid="chat-model-selector" class="tw-border-none tw-flex tw-items-center focus-visible:tw-outline-none tw-justify-between tw-mr-1 _button_1wufw_5 _button--secondary_1wufw_60 _button--no-icon-start_1wufw_51">…</button> - unexpected value "Agentic chatExperimental" - locator resolved to <button type="button" role="combob

	// Change selection to Titan and assert it was updated
	// Note: currently the backend doesn't respect frontend enterprise