Add note to PR guidelines #541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the review process duration and added clarification on feedback and merging.
RemFexxel
reviewed
Oct 26, 2025
src/en/general-development/codebase-info/pull-request-guidelines.md
Outdated
Show resolved
Hide resolved
VasilisThePikachu
approved these changes
Oct 27, 2025
Member
VasilisThePikachu
left a comment
VasilisThePikachu
left a comment
There was a problem hiding this comment.
Fine on the idea of wording. Not good with grammar so someone else can look at that
Co-authored-by: Rem <[email protected]>
Contributor
There's no grammar issues I could find. Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the last maintainer meeting.
In case you have a better formulation for this, let me know.
I also changed "several weeks" to "several months" because the backlog is massive.