Skip to content

Add note to PR guidelines #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add note to PR guidelines #541

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2939fb
Revise pull request review guidelines
slarticodefast Oct 25, 2025
b028e41
Update pull-request-guidelines.md
ArtisticRoomba Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/en/general-development/codebase-info/pull-request-guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,9 @@ You are free to make changes to your PR after submitting, for example, if you ma

# Reviews

Reviews are an important part of the pull request process. Reviews help us obtain feedback from the community and maintain a high quality of code in the codebase. Since maintainers are volunteers, we ask for your patience. The review process for large changes can take up to several weeks.
Reviews are an important part of the pull request process. Reviews help us obtain feedback from the community and maintain a high quality of code in the codebase. Since maintainers are volunteers, we ask for your patience. The review process for large changes can take up to several months.

We appreciate and consider all player feedback. However, maintainers ultimately have the final say on which changes are merged into the repository. Keep in mind that even if a PR is merged, it may be reverted as part of the next maintainer meeting and may not end up in the next stable release. See our [release model](./releases.md) for more details.

## Getting Reviews

Expand Down
Loading