Update rscd model for new MIRI subarrays

[jemorrison]

Is needed for https://jira.stsci.edu/browse/JWSTMIRI-506

In support of JP-4279
and JP-4144

This PR increases the subarray and readpatt string length in the RSCD datamodels to accommodate the longer string
names for the new MIRI subarrays (SLITLESSPRISM_IP, SLITLESSPRIM_IPS) and new readout pattern: FASTGRPAVE8.

This PR needs to be merged before the new RSCD reference file with the new subarray can be delivered to CRDS

Tasks

• update or add relevant tests
• update relevant docstrings and / or docs/ page
• Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
  • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
  • run jwst regression tests with this branch installed ("git+https://github.com/<fork>/stdatamodels@<branch>")

news fragment change types...

• changes/<PR#>.feature.rst: new feature
• changes/<PR#>.bugfix.rst: fixes an issue
• changes/<PR#>.doc.rst: documentation change
• changes/<PR#>.removal.rst: deprecation or removal of public API
• changes/<PR#>.misc.rst: infrastructure or miscellaneous change

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (904f3c1) to head (72216ef).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #758   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files          99       99           
  Lines        4619     4619           
=======================================
  Hits         4188     4188           
  Misses        431      431           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[emolter]

I only see "FASTGRPAVG8" as an enum option in readpatt and preadpatt, but not subarray. Does it need to be added to the subarray enum list? will it actually be used as a subarray or only a read pattern?

[tapastro]

I think the subarray length increase is required to accommodate "SLITLESSPRISM_IPS".

We should link our work to JP tickets - if one does not exist that's relevant for this PR, we should file one. I'll find the JP ticket for FASTGRPAVG8 support and link it.

[jemorrison]

FASTGRPAVG8 is not a sub-array but a read pattern.
I just know of the MIRI ticket - I can created a JWST one - but this is not to implement FASTGRPAVG8 but just support the new reference files need for the new subarrays that MIRI is using.
Is there a ticket for the MIRI subarrays in JIRA ?

[emolter]

thanks Jane and Tyler, the reason I asked is because it initially didn't seem necessary to update subarray if FASTGRPAVG8 is not a subarray. Makes sense about SLITLESSPRISM_IPS although it's a tiny bit concerning that this was added in a prior PR without updating the string length. I wonder if we need to have some way to test this

[tapastro]

I think it's rare for one of our datamodels to set explicit string length limits - I didn't realize one existed in this datamodel. It may not be worth the headache.

EDIT: I'm just out of touch, this is typical for any string stored as part of a FITS table. My bad!

[jemorrison]

@emolter @tapastro Can you remind me - do I run the regression tests ? There is no data with these types of subarrays or readpatt. And not reference file is in CRDS with these options

[jemorrison]

@emolter I was thinking a change log was not needed - is one ?

[emolter]

I'm fine without a changelog entry. Regtests would be good although there's very little chance anything goes wrong