adiak: Update Package for v0.5.0 Release #2300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@spackbot maintainers |
16 tasks
michaelmckinsey1
force-pushed
the
update-adiak-python
branch
from
5350374 to
ad3ec73
Compare
Author
michaelmckinsey1
changed the title
Contributor
|
Looks good to me |
daboehme
approved these changes
Dec 15, 2025
scheibelp
reviewed
Dec 22, 2025
| depends_on("mpi", when="+mpi") | ||
|
|
||
| depends_on("python@3", when="+python", type=("build", "link", "run")) | ||
| depends_on("[email protected]:", when="+python", type=("build", "link", "run")) |
Member
There was a problem hiding this comment.
If you add extends(python, when=+python), then it should not be required to define setup_run_environment below; you could bundle that with the 2 above statements like:
with when("+python"):
extends("python")
depends_on("python@3:", type=("build", "link", "run"))
depends_on("[email protected]:", type=("build", "link", "run"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are package updates related to the v0.5.0 release of Adiak (https://github.com/LLNL/Adiak/releases/tag/v0.5.0)
0.5.0as a newversion+pythonto enable the bindings onmaster. I have tested these changes manually in conjunction with the caliper python bindings, which already exist.