Ginkgo: add PAPI SDE support #39425
Merged
Ginkgo: add PAPI SDE support #39425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcojean
force-pushed
the
ginkgo_papi_sde
branch
from
b2aedfb to
f994fe0
Compare
alalazo
requested changes
Nov 13, 2023
Comment on lines
75
to
76
| conflicts("+sde", when="@:1.6.0") | ||
| conflicts("+sde", when="@master") |
Member
There was a problem hiding this comment.
Hmm, I don't get it. Are you adding a variant that always conflicts?
Member
There was a problem hiding this comment.
Oh, this works only on develop Can you make it clear and enable the variant only when=@develop and remove the conflicts?
Contributor
Author
There was a problem hiding this comment.
Thanks, this is not the case anymore after #40874 I will update it.
alalazo
requested changes
Nov 13, 2023
Comment on lines
75
to
76
| conflicts("+sde", when="@:1.6.0") | ||
| conflicts("+sde", when="@master") |
Member
There was a problem hiding this comment.
Oh, this works only on develop Can you make it clear and enable the variant only when=@develop and remove the conflicts?
tcojean
force-pushed
the
ginkgo_papi_sde
branch
from
f994fe0 to
51a4387
Compare
alalazo
reviewed
Nov 14, 2023
| variant("sycl", default=False, description="Enable SYCL backend") | ||
| variant("develtools", default=False, description="Compile with develtools enabled") | ||
| variant("hwloc", default=False, description="Enable HWLOC support") | ||
| variant("sde", default=False, description="Enable PAPI SDE support") |
Member
There was a problem hiding this comment.
You can also:
Suggested change
| variant("sde", default=False, description="Enable PAPI SDE support") | |
| variant("sde", default=False, description="Enable PAPI SDE support", when="@1.7:") |
Comment on lines
80
to
84
| conflicts("+sde", when="@:1.6.0") | ||
|
|
Member
There was a problem hiding this comment.
And delete these lines:
Suggested change
| conflicts("+sde", when="@:1.6.0") |
Contributor
Author
There was a problem hiding this comment.
Thanks! I forgot I could do it this way
alalazo
force-pushed
the
ginkgo_papi_sde
branch
from
facefaf to
74ff31c
Compare
alalazo
previously approved these changes
Feb 22, 2024
auto-merge was automatically disabled
February 27, 2024 12:21
Head branch was pushed to by a user without write access
tcojean
force-pushed
the
ginkgo_papi_sde
branch
from
74ff31c to
d28c1b6
Compare
alalazo
requested changes
Feb 27, 2024
Signed-off-by: Terry Cojean <[email protected]> Co-authored-by: Massimiliano Culpo <[email protected]>
tcojean
force-pushed
the
ginkgo_papi_sde
branch
from
d10ae87 to
8eef2b2
Compare
Member
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
alalazo
approved these changes
Feb 28, 2024
mathomp4
pushed a commit
to mathomp4/spack
that referenced
this pull request
Mar 27, 2024
Signed-off-by: Terry Cojean <[email protected]> Co-authored-by: Massimiliano Culpo <[email protected]>
teaguesterling
pushed a commit
to teaguesterling/spack
that referenced
this pull request
Jun 15, 2024
Signed-off-by: Terry Cojean <[email protected]> Co-authored-by: Massimiliano Culpo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option
+sdewhich enables PAPI Software Define Events (SDE).This allows other libraries to access software-defined Ginkgo counters through the standard PAPI interfaces.
Currently, only the most recent Ginkgo version (develop) and the most recent PAPI (master) is supported.