Skip to content

Ginkgo: add PAPI SDE support #39425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alalazo merged 4 commits into from
Feb 29, 2024
Merged

Ginkgo: add PAPI SDE support #39425

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4dab47b
Ginkgo: add PAPI SDE support
Aug 11, 2023
6803f14
Ginkgo+PAPI SDEs: master is now supported
Nov 13, 2023
8eef2b2
Ginkgo: cleanup options & conflicts
Nov 14, 2023
c2de447
ginkgo: better MPI variant selection
Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions var/spack/repos/builtin/packages/ginkgo/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ class Ginkgo(CMakePackage, CudaPackage, ROCmPackage):
variant("sycl", default=False, description="Enable SYCL backend")
variant("develtools", default=False, description="Compile with develtools enabled")
variant("hwloc", default=False, description="Enable HWLOC support")
variant("mpi", default=False, description="Enable MPI support")
variant("sde", default=False, description="Enable PAPI SDE support", when="@1.7.0:")
variant("mpi", default=False, description="Enable MPI support", when="@1.5.0:")

depends_on("[email protected]:", type="build", when="@:1.3.0")
depends_on("[email protected]:", type="build", when="@1.4.0:1.6.0")
Expand All @@ -68,6 +69,8 @@ class Ginkgo(CMakePackage, CudaPackage, ROCmPackage):
# setup for rocthrust, this needs to also be added here.
depends_on("rocprim", when="+rocm")
depends_on("[email protected]:", when="+hwloc")
# TODO: replace with the next PAPI version when available (>7.0.1.0)
depends_on("papi@master+sde", when="+sde")

depends_on("googletest", type="test")
depends_on("numactl", type="test", when="+hwloc")
Expand All @@ -78,7 +81,6 @@ class Ginkgo(CMakePackage, CudaPackage, ROCmPackage):

conflicts("%gcc@:5.2.9")
conflicts("+rocm", when="@:1.1.1")
conflicts("+mpi", when="@:1.4.0")

# ROCm 4.1.0 breaks platform settings which breaks Ginkgo's HIP support.
conflicts("^[email protected]:", when="@:1.3.0")
Expand Down Expand Up @@ -151,6 +153,7 @@ def cmake_args(self):
from_variant("BUILD_SHARED_LIBS", "shared"),
from_variant("GINKGO_JACOBI_FULL_OPTIMIZATIONS", "full_optimizations"),
from_variant("GINKGO_BUILD_HWLOC", "hwloc"),
from_variant("GINKGO_WITH_PAPI_SDE", "sde"),
from_variant("GINKGO_DEVEL_TOOLS", "develtools"),
# As we are not exposing benchmarks, examples, tests nor doc
# as part of the installation, disable building them altogether.
Expand Down