Skip to content

Separate node and partition configuration #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2025
Merged

Separate node and partition configuration #189

merged 2 commits into from
May 16, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented May 15, 2025

This repeats #183 which was reverted in ed717da to allow #186 to be merged.


Replaces openhpc_slurm_partitions with openhpc_nodegroups and openhpc_partitions, to make complex partition configurations correct. Previously it would have been possible to define nodes twice, with different parameters, and only the first occurance would have been used.

As part of these changes this:

  • Adds nodegroup.node_params to allow specifying additional Node-level parameters
  • Adds nodegroup.features to allow specifying additional Node features
  • Removes openhpc_slurm_partitions.cluster_name
  • Removes openhpc_slurm_partitions.extra_nodes

@sjpb sjpb requested a review from a team as a code owner May 15, 2025 12:31
@sjpb sjpb merged commit 5bce8de into master May 16, 2025
29 checks passed
@sjpb sjpb deleted the feat/nodegroups-v2 branch May 16, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants