Fix bridge_regression_test build after reserved-meta API rename - #6029
Merged
Conversation
Main was red: #6024 renamed mcpparser.ReservedModernMetaKeys / StripReservedModernMeta to ReservedMetaPrefix / StripReservedMeta (with passthroughMetaKeys), and #6006's bridge_regression_test.go still referenced the removed identifier, breaking typecheck on the merge commit (Linting / Lint Go Code and Tests / Test Go Code both failed). Assert on the reserved namespace (ReservedMetaPrefix) instead of the removed fixed list — the same pattern revision_realbackend_test.go already uses. This is also strictly stronger: it catches any reserved key the spec adds later, and no passthroughMetaKeys entry rides a tools/call, so the blanket prefix check is exact.
JAORMX
requested review from
ChrisJBurns,
amirejaz,
jerm-dro,
jhrozek and
tgrunnagle
as code owners
July 27, 2026 15:54
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6029 +/- ##
==========================================
+ Coverage 72.15% 72.17% +0.01%
==========================================
Files 721 721
Lines 74991 75025 +34
==========================================
+ Hits 54113 54148 +35
- Misses 17015 17018 +3
+ Partials 3863 3859 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jhrozek
approved these changes
Jul 27, 2026
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main was red.
Linting / Lint Go CodeandTests / Test Go Codeboth failed on #6006's merge commit (08cbffd):#6024 renamed the reserved-
_metaAPI —ReservedModernMetaKeys/StripReservedModernMeta→ReservedMetaPrefix/StripReservedMeta(withpassthroughMetaKeys) — and #6006'sbridge_regression_test.gostill referenced the removed identifier. The two PRs crossed in flight.Fix: assert on the reserved namespace (
mcpparser.ReservedMetaPrefix) instead of the removed fixed list — the same patternrevision_realbackend_test.go:163already uses. This is strictly stronger than the old list: it catches any reserved key the spec adds later, and since nopassthroughMetaKeysentry rides atools/call, a blanket prefix check is exact. Also updated the staleStripReservedModernMetareference in the doc comment.Type of change
Test plan
task test) — fullpkg/vmcp/serverpackage green with-race; the previously-brokenTestRegression_BridgeCellA_NoReservedMetaLeakToLegacyBackendcompiles and passestask lint-fix) — 0 issuesAPI Compatibility
v1beta1API.Test-only change.
Does this introduce a user-facing change?
No.