Skip to content

Fix bridge_regression_test build after reserved-meta API rename #6029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JAORMX merged 1 commit into from
Jul 27, 2026
Merged

Fix bridge_regression_test build after reserved-meta API rename #6029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions pkg/vmcp/server/bridge_regression_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (
"net/http"
"net/http/httptest"
"slices"
"strings"
"sync"
"testing"
"time"
Expand Down Expand Up @@ -468,7 +469,7 @@ func TestRegression_BridgeCellA_PerPrincipalSessionIsolation(t *testing.T) {
// keys, but vMCP -- not the downstream caller -- is the Legacy backend's MCP
// peer on this hop, and go-sdk v1.7 hard-rejects (HTTP 400) ANY
// _meta.protocolVersion on a stateful server. legacyCallTool strips them via
// mcpparser.StripReservedModernMeta before forwarding
// mcpparser.StripReservedMeta before forwarding
// (pkg/vmcp/client/client.go); this asserts the Legacy backend receives NO
// io.modelcontextprotocol/* key in the tools/call request body it actually
// gets. Request path only -- response _meta is issue #5986's scope.
Expand Down Expand Up @@ -503,10 +504,12 @@ func TestRegression_BridgeCellA_NoReservedMetaLeakToLegacyBackend(t *testing.T)
sawToolCall = true
params, _ := r.body["params"].(map[string]any)
meta, _ := params["_meta"].(map[string]any)
for _, reserved := range mcpparser.ReservedModernMetaKeys {
_, present := meta[reserved]
assert.False(t, present,
"Legacy backend must never see reserved Modern _meta key %q on the request path; got %+v", reserved, meta)
// Assert on the namespace, not a fixed list: this catches any reserved
// key, including ones the spec adds later. No passthroughMetaKeys entry
// is in play on a tools/call, so a blanket prefix check is exact.
for k := range meta {
assert.False(t, strings.HasPrefix(k, mcpparser.ReservedMetaPrefix),
"Legacy backend must never see reserved _meta key %q on the request path; got %+v", k, meta)
}
assert.Equal(t, "n1", meta["vmcp.test/nonce"],
"the strip must be surgical, not a blanket _meta drop; got %+v", meta)
Expand Down
Loading