Review Request: Rough Implementation of LBR on Memtrace#8
Open
takhandipu wants to merge 111 commits into
Open
Conversation
…n take lbr (by feault nullptr)
… with Professor Litz regarding that
…on it, again have to check with Professor Litz
…ntation is complete
…s are not so good yet
…NeverUsed counters based on 400 cycle difference from req->cycle and candidate's startCycle
…her it runs or not
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello Professor Litz,
Can you have a look at my LBR implementation? You don't have to merge this pull request to the original memtrace branch, I just wanted to be double sure about the accuracy of our LBR implementation. Since the accuracy and speedup of our simulation depends on the accuracy of LBR, I would greatly appreciate if you could at least review the changes and see whether the LBR implementation makes sense. Thanks once again for your help.
Kind regards,
Tanvir Ahmed Khan.