Hash spec markers with a const SHA-256 - #2080
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
leighmcculloch
added this pull request to stack #2081
September 22, 2026 10:12
This was referenced Sep 22, 2026
leighmcculloch
force-pushed
the
const-sha256-for-spec-markers
branch
from
September 22, 2026 12:08
0f3a201 to
7bac828
Compare
leighmcculloch
force-pushed
the
const-sha256-for-spec-markers
branch
2 times, most recently
from
September 22, 2026 12:47
4465d1e to
8b2aac3
Compare
leighmcculloch
marked this pull request as ready for review
September 22, 2026 12:47
1 of 3 tasks
This comment was marked as outdated.
This comment was marked as outdated.
leighmcculloch
force-pushed
the
const-sha256-for-spec-markers
branch
from
September 23, 2026 06:57
87c3a1f to
8aacaf3
Compare
leighmcculloch
force-pushed
the
const-sha256-for-spec-markers
branch
from
September 25, 2026 00:32
82cbe23 to
23f0dc1
Compare
leighmcculloch
marked this pull request as draft
September 25, 2026 11:24
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The package omits test vectors required at compile time, and the fuzz job lacks generic CPU flags.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
Resolved since last review (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Part of a stack of PRs listed here:
What
Make the function
soroban_spec::shaking::generate_marker_for_xdrcallable in const contexts and in nostd crates.Caution
Replaces the use of the
sha2crate for hashing the spec entries with an in-repo const-compatible sha256 implementation.Why
So that the function can be called from within Soroban contracts, in the definition of a static variable. In the stack of PRs above the PR after this shifts to building XDR into a const, and the XDR will no longer be known at proc-macro execution time. The function
generate_marker_for_xdris currently called from within the proc-macros, but because the XDR will not be known until const evaluation, the marker generation will also need to move to const evaluation.SemVer Change
vX._._) - Breaking change to the public API.v_.Y._) - Additive change to the public API.v_._.Z) - No change to the public API.Fuzz Coverage
Generated by Claude Code