Reduce qualified type and event names

[leighmcculloch]

Note

Part of a stack of PRs listed here:

• Fixing a few issues with the soroban-sdk's production of specs (type ids, name collisions, aliasing, ...) stellar-protocol#2014

What

Reduce the fully qualified UDT type names that stellar/rs-soroban-sdk#1970 emits (e.g. my_contract::inner::State) down to short names during the build process.

Why

The soroban-sdk will be emitting fully qualified user-defined type names as an intermediary step so that the stellar-cli can reduce the spec to only those types needed by the exported interface of a contract, and so that types will be guaranteed to have unique names. The long names are not good for most tooling though which is already accustomed to the short simple names. The cli can make this change in the soroban-sdk a no-op for the rest of the ecosystem by converting the names to unique simple names during the build step.

[Copilot]

Copilot review overview

🔵 Needs a closer look

Five unresolved moderate findings remain across build-path coverage, safety, testing, and warning accuracy.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Multiple moderate issues remain unresolved, including artifact reduction correctness and output sanitization.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Four moderate issues remain unresolved across correctness, security, testing, and container-build handling.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved findings affect name rewriting, warning safety, integration coverage, container builds, and diagnostics.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues affect build-mode consistency, undefined-reference handling, output sanitization, and integration test coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved moderate issues affect reference rewriting, container builds, output sanitization, and test coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🟡 Changes recommended

A critical API mismatch prevents compilation, and several build-path, sanitization, warning, and test coverage issues remain.

Review effort: Lite
Findings: 1 · 3 · 1

Open (5)

• Use the pinned non-fallible soroban-spec reduction API · New
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues remain around reduction detection, warning sanitization, container builds, and integration coverage.

Review effort: Lite
Findings: 1 · 3 · 1

Open (5)

• Use the pinned non-fallible soroban-spec reduction API
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues affect correctness, safety, coverage, and consistency across build paths.

Review effort: Lite
Findings: 1 · 3 · 1

Open (5)

• Use the pinned non-fallible soroban-spec reduction API
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved moderate issues affect build behavior, output correctness, warning safety, and regression coverage.

Review effort: Lite
Findings: 3 · 1

Open (4)

• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

Resolved since last review (1)

• Use the pinned non-fallible soroban-spec reduction API

[Copilot]

Copilot review overview

🟡 Changes recommended

Multiple moderate issues remain unresolved, including a compilation blocker and incomplete build-path handling.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation · New
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved correctness, security, and test-coverage issues remain.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved correctness, safety, container-path, and integration-testing issues remain.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names

[Copilot]

Copilot review overview

🔵 Needs a closer look

Unresolved issues remain around sanitization, integration coverage, image builds, and event-name diagnostics.

Review effort: Lite
Findings: 4 · 1

Open (5)

• Add coverage for nested references, events, and collision disambiguation
• Sanitize rename values before including them in warnings
• Detect reductions for undefined UDT references
• Add build integration coverage for spec name reduction
• Collision warning should include event names