SPIKE: Protocol 28 (CAP-0084)#549
Closed
sisuresh wants to merge 3 commits into
Closed
Conversation
Bump xdr submodule to stellar-xdr#306 head (7b56181), add the cap_0084_muxed_contract feature, and regenerate. Adds the SC_ADDRESS_TYPE_MUXED_CONTRACT arm on ScAddress and the MuxedContract struct, gated behind cap_0084_muxed_contract. str.rs: ScAddress Display is hand-written (CUSTOM_STR_IMPL); muxed contract addresses have no strkey encoding yet, so that arm returns Err — flagged for human review. Bumps crate version to 28.0.0.
This was referenced Jun 26, 2026
SPIKE: Protocol 28 (CAP-0084): muxed contract address support in the SAC
stellar/rs-soroban-env#1696
Closed
Contributor
Author
|
Downstream SPIKE consuming this branch: stellar/rs-soroban-sdk#1922 (Protocol 28 / CAP-0084). |
This was referenced Jun 27, 2026
Contributor
Author
|
Closing — this stack will be regenerated from scratch by the automated protocol-release flow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIKE: Protocol 28 (CAP-0084) — Muxed Contract Addresses
Regenerates the Rust XDR codec for CAP-0084, gated behind the
cap_0084_muxed_contractfeature. AddsScAddress::MuxedContract/SC_ADDRESS_TYPE_MUXED_CONTRACTand theMuxedContractstruct.Upstream: stellar/stellar-xdr#306 (head 7b56181). The xdr submodule
pins that commit directly from stellar/stellar-xdr — no fork URL needed;
re-pin to the merged main SHA once #306 lands.
ScAddressDisplay (src/str.rs, hand-writtenCUSTOM_STR_IMPL) returns
Errfor the muxed-contract arm — there is nostrkey encoding for muxed contract addresses yet (stellar-strkey has no
variant). Stub to be replaced when strkey support lands.
Draft until #306 merges.