Repository navigation
Uptake stellar-asset-spec crate from refactoring in rs-soroban-sdk PR#1536 - #2173
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
anupsdf
marked this pull request as draft
August 29, 2025 05:48
anupsdf
marked this pull request as ready for review
August 29, 2025 06:12
anupsdf
marked this pull request as draft
August 29, 2025 06:25
…field in transfer fn
…field in transfer fn
anupsdf
force-pushed
the
uptake_soroban-token-spec
branch
from
August 29, 2025 07:05
99bcbb8 to
a2919e7
Compare
leighmcculloch
left a comment
leighmcculloch
left a comment
Member
There was a problem hiding this comment.
Thanks for taking this on! ❤️
anupsdf
commented
Aug 29, 2025
anupsdf
marked this pull request as ready for review
August 29, 2025 07:37
anupsdf
marked this pull request as draft
August 29, 2025 15:52
anupsdf
commented
Aug 29, 2025
anupsdf
commented
Aug 29, 2025
anupsdf
marked this pull request as ready for review
August 29, 2025 18:23
anupsdf
enabled auto-merge (squash)
August 29, 2025 18:23
dmkozh
reviewed
Aug 29, 2025
leighmcculloch
left a comment
leighmcculloch
left a comment
Member
There was a problem hiding this comment.
One change requested inline, otherwise this lgtm.
leighmcculloch
approved these changes
Aug 31, 2025
Contributor
|
Thanks a lot @anupsdf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
StellarAssetSpec got refactored in stellar/rs-soroban-sdk#1536
This PR is to adapt to the new crate stellar-asset-spec v23.0.0-rc.3
Plus pick up the dependencies from other crates released within rs-soroban-sdk v23.0.0-rc.3.