Correct manageBuyOffer cancel parameter in trustline removal - #91
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Corrects trustline-removal guidance for Stellar offer cancellation and liquidity-pool constraints.
Changes:
- Uses
buyAmount: "0"formanageBuyOffercancellation. - Clarifies that liquidity-pool usage surfaces as
op_cannot_delete.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Automated message from Kaan's Automated Triage Bot.
Follow-up to #90, addressing both points from Copilot's review there:
manageBuyOffercancels withbuyAmount: "0"(notamount), and the preflight snippet now notes that liquidity-pool usage (precondition 4) is not visible on the balance line and surfaces asop_cannot_deleteat submit.