Skip to content

Correct manageBuyOffer cancel parameter in trustline removal #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaankacar merged 1 commit into from
Aug 13, 2026
Merged

Correct manageBuyOffer cancel parameter in trustline removal #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions skills/assets/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,8 +251,8 @@ is in a deletable state. Before submitting:
2. **Clear the balance.** The trustline balance must be exactly `0` — send
remaining funds back to the issuer (burns them) or to another account.
3. **Clear offers / buying liabilities.** Open DEX offers that buy the asset
create buying liabilities; cancel them (`manageSellOffer`/`manageBuyOffer`
with `amount: "0"`) before removal.
create buying liabilities; cancel them before removal (`manageSellOffer`
with `amount: "0"`, `manageBuyOffer` with `buyAmount: "0"`).
4. **Exit liquidity pool positions.** An asset trustline referenced by a
liquidity pool (`liquidity_pool_use_count > 0`, per CAP-0038) cannot be
deleted — withdraw from the pool and remove the pool-share trustline first.
Expand All @@ -274,6 +274,10 @@ if (parseFloat(trustline.balance) !== 0)
if (parseFloat(trustline.buying_liabilities) !== 0)
throw new Error("Cancel open offers buying this asset first");

// Liquidity-pool usage (precondition 4) is not visible on this balance line —
// if the asset is still in one of the account's pools, the submit below fails
// with op_cannot_delete. Withdraw and remove the pool-share trustline first.

// 2. Submit removal and surface the specific result code
const removeTrustTx = new StellarSdk.TransactionBuilder(account, {
fee: StellarSdk.BASE_FEE,
Expand Down
Loading